Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow headers on http probes #255

Open
jcmuller opened this issue Sep 27, 2024 · 1 comment
Open

Allow headers on http probes #255

jcmuller opened this issue Sep 27, 2024 · 1 comment

Comments

@jcmuller
Copy link

Feature Request

Use Case:

Vite dev server supports ping requests. Not on a path (why would it /s) but instead when passing in the Accept: text/x-vite-ping header.

I would much prefer to use the native http probe rather than having to use an exec one and using curl or similar.

Proposed Change:

Allow headers to be passed into the HTTP liveness and readiness probes.

Who Benefits From The Change(s)?

At least anyone who wants to use vite. There will be other cases.

Alternative Approaches

Use an exec probe with curl or similar.

@jcmuller
Copy link
Author

If this seems like a good idea I can submit a patch for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant