Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialplan custom #106

Merged
merged 6 commits into from
Apr 20, 2018
Merged

Dialplan custom #106

merged 6 commits into from
Apr 20, 2018

Conversation

ovv
Copy link
Contributor

@ovv ovv commented Apr 19, 2018

Current dialplan was not correct and complicated. This rework
simplify it greatly and provide an easy way to do your own routing

I think it will be a nice place to put helpers for
authentifications.

No idea if that will provide any advantages over a flat mapping
of methods / middlewares

issue #78

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #106 into master will increase coverage by 0.39%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   70.48%   70.87%   +0.39%     
==========================================
  Files          15       15              
  Lines        1562     1528      -34     
  Branches      267      264       -3     
==========================================
- Hits         1101     1083      -18     
+ Misses        342      328      -14     
+ Partials      119      117       -2
Impacted Files Coverage Δ
aiosip/dialplan.py 100% <100%> (+40%) ⬆️
aiosip/application.py 71.81% <85.71%> (+0.57%) ⬆️
aiosip/dialog.py 73.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ea3c3...653f616. Read the comment docs.

Copy link
Contributor

@vodik vodik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. And I suspect your right.

If anything, maybe it makes sense to stack/nest dialplans rather than trying to support middleware directly: e.g. outer layer handles authentication, then lets the next layer resolve

ovv added 6 commits April 20, 2018 10:24
Current dialplan was not correct and complicated. This rework
simplify it greatly and provide an easy way to do your own routing

I think it will be a nice place to put helpers for
authentifications.

No idea if that will provide any advantages over a flat mapping
of methods / middlewares

issue #78
@ovv ovv force-pushed the dialplan-custom branch from 9827d1b to 653f616 Compare April 20, 2018 08:24
@ovv ovv merged commit 92eea1e into master Apr 20, 2018
@ovv ovv deleted the dialplan-custom branch April 25, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants