Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump net45 to net452 #276

Closed
Mike-E-angelo opened this issue Nov 12, 2019 · 3 comments · Fixed by #331
Closed

Bump net45 to net452 #276

Mike-E-angelo opened this issue Nov 12, 2019 · 3 comments · Fixed by #331
Assignees
@Mike-E-angelo
Labels
breaking change This is going to break something fierce
Milestone
v3.0.0

Comments

@Mike-E-angelo
Copy link
Member

Based on our discussion with #273, let's bump our net45 build to net452 as net45 is no longer supported by MSFT:

https://dotnet.microsoft.com/download/dotnet-framework
@Mike-E-angelo Mike-E-angelo added the continuous integration (cc: ci) Workflow process for proper build, testing, and deployment of new code label Nov 12, 2019
@Mike-E-angelo Mike-E-angelo self-assigned this Nov 12, 2019
@Mike-E-angelo Mike-E-angelo added this to the v2.1.26 milestone Nov 12, 2019
@Mike-E-angelo
Copy link
Member Author

Mike-E-angelo commented Nov 13, 2019 •
edited
Loading

Hey @WojciechNagorski I think we should make 2.1.26 the 2.2.0 release instead... what do you think? It will include:

  • Documentation (!)
  • Fluent API adjustments (I've been having to do a few and in turn obsolete some calls -- examples here and here)
  • Minimum supported .NET Framework version (4.5.2)

That seems like enough to bump to a new minor version. Any thoughts?

@WojciechNagorski
Copy link
Member

@Mike-EEE It is a good idea. 👍

@Mike-E-angelo Mike-E-angelo mentioned this issue Nov 30, 2019
Closed
@Mike-E-angelo Mike-E-angelo added breaking change This is going to break something fierce and removed continuous integration (cc: ci) Workflow process for proper build, testing, and deployment of new code labels Nov 30, 2019
@Mike-E-angelo
Copy link
Member Author

Mike-E-angelo commented Nov 30, 2019 •
edited
Loading

After some serious consideration over this, since this does introduce a breaking change (along with #285 and #189), it's better to version this to v3.0.0 to be compliant with semantic versioning.

#289 has the details.

I know we had set "v3" to be a big re-write, but we'll have to adjust because of these changes. I think it might be best to put that in a different repository in our new ExtendedXmlSerializer Organization, now that we have one. Still thinking about it. :)

This was referenced Nov 30, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mike-E-angelo Mike-E-angelo

Labels
breaking change This is going to break something fierce
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Upgraded minimum .NET version to 4.5.2 ExtendedXmlSerializer/home
2 participants
@Mike-E-angelo @WojciechNagorski