Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul AssemblyNameRegex #29

Open
bddckr opened this issue Feb 16, 2019 · 0 comments
Open

Overhaul AssemblyNameRegex #29

bddckr opened this issue Feb 16, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@bddckr
Copy link
Contributor

bddckr commented Feb 16, 2019

AssemblyNameRegex in the FodyWeavers.xml files should be restricting the assemblies the particular configuration file affects.

Currently the setting just gets merged across files, but it makes more sense to allow setting all settings, including the list of weavers to run for specific assemblies. This allows a library component to use Malimbe (configured with the library's settings) while also allowing any user of that library to use Malimbe with different settings.

Perhaps AssemblyNameRegex should move into the root-level element Weavers instead? This would need to still allow specifying multiple assemblies, which should be easily possible since it's treated as a regex after all.

@bddckr bddckr added the enhancement New feature or request label Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant