Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect_number not working as expected? #2

Open
skasai5296 opened this issue Aug 23, 2019 · 2 comments
Open

detect_number not working as expected? #2

skasai5296 opened this issue Aug 23, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@skasai5296
Copy link

Thanks for the great repo!

I was looking at how you parsed the captions, but in adversarial_attack/numeral.py the program
hangs with a sentence ending in a number, with no period.

detect_number("she is 13")

I made a workaround by converting line 24, continue to break. Could this cause unintended behavior?

@skasai5296
Copy link
Author

I guessed that this function takes the numbers that have nouns after them, but I think this wouldn't cause much problem in that case.
A non-working case would be "the number of zebras in this picture is three" but it is an unlikely case though...

@ExplorerFreda
Copy link
Owner

ExplorerFreda commented Sep 12, 2019

Hi -- Thanks for pointing out this! You've successfully found a bug. I'd try to work it out.

@ExplorerFreda ExplorerFreda self-assigned this Sep 12, 2019
@ExplorerFreda ExplorerFreda added the bug Something isn't working label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants