Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove string selector from the option passed to withOnyx #285

Closed
1 task
hayata-suenaga opened this issue Jul 25, 2023 · 1 comment
Closed
1 task

Remove string selector from the option passed to withOnyx #285

hayata-suenaga opened this issue Jul 25, 2023 · 1 comment
Assignees
@hayata-suenaga
Labels
Daily

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Jul 25, 2023 •
edited
Loading

Per this Slack proposal: https://expensify.slack.com/archives/C01GTK53T8Q/p1689878289580419
Per this comment in the TS + Onyx PR: #267 (comment)
@hayata-suenaga hayata-suenaga self-assigned this Jul 25, 2023
This was referenced Jul 25, 2023
Merged
Closed
Closed
Merged
@hayata-suenaga hayata-suenaga mentioned this issue Aug 7, 2023
Closed
56 tasks
@hayata-suenaga
Copy link
Contributor Author

The PR for removeing the string selector has been merged and the PR for bumping the onxy version in App is up. So closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayata-suenaga hayata-suenaga

Labels
Daily
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hayata-suenaga