Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense - RBR appears on the expense preview when there is no violation #52562

Closed
5 of 8 tasks
IuliiaHerets opened this issue Nov 14, 2024 · 8 comments
Closed
5 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.62-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense.
  3. Enter amount > Next.
  4. Select any user with no unsettled expense.
  5. On confirmation page, add a receipt.
  6. Submit the expense with receipt.

Expected Result:

Describe what you think should've happened

Actual Result:

RBR will not appear on the expense preview in the main chat if there is no violation (production behavior).

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6665176_1731588080772.20241114_203817.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 14, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 14, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Nodebrute
Copy link
Contributor

Probably a regression from #52478

@iwiznia
Copy link
Contributor

iwiznia commented Nov 14, 2024

Looking into this. Context https://expensify.slack.com/archives/C03TQ48KC/p1731598521545959

@iwiznia iwiznia added the Reviewing Has a PR in review label Nov 14, 2024
@iwiznia iwiznia assigned iwiznia and unassigned marcochavezf Nov 14, 2024
@kavimuru
Copy link

Not reproducible

bandicam.2024-11-14.16-26-10-859.mp4

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Nov 14, 2024
@iwiznia
Copy link
Contributor

iwiznia commented Nov 15, 2024

Nice, the fix worked then

@iwiznia iwiznia closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants