[$250] Expense - Expense amount is not added but substracted when submitting from the expense report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Submit expense > Manual.
3. Submit a manual expense to any user.
4. In the main chat, click on the expense preview.
5. In the expense report, click + > Submit expense > Manual (important).
6. Submit a manual expense of the same amount in Step 3.

Expected Result:

The total amount of the expenses will be calculated correctly.

Actual Result:

The expense amount is 0.00.
Expense amount is not added but substracted when submitting from the expense report

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642009_1729600385033.20241022_203023.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848735249840900998
• Upwork Job ID: 1848735249840900998
• Last Price Increase: 2024-10-22

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848735249840900998

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[flodnv]

I reproduced and can confirm this is a bug only on staging, and probably a blocker.

[flodnv]

Strange, I can't reproduce on the latest main.

[bernhardoj]

The RequestMoney API returns the total as 0

[flodnv]

Looking at server logs, I'm wondering if this is because the first RequestMoney creates the transaction with a negative amount, and subsequent ones create the transaction with a positive amount

[flodnv]

@bernhardoj are you able to reproduce on the latest main?

[flodnv]

I think this is happening because the App code on staging is sending a policyID when it should not be.

[flodnv]

Caused by this PR #49412

Removing this line fixes this bug.

[flodnv]

I'm proposing we revert the PR: https://expensify.slack.com/archives/C01GTK53T8Q/p1729612151981119

[flodnv]

@ishpaul777 is taking over this.

[melvin-bot]

@flodnv @lschurr @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[flodnv]

This was fixed

[melvin-bot]

@flodnv @lschurr Be sure to fill out the Contact List!