[HOLD for payment 2024-11-20] [$250] FAB - Track expense option is not present in FAB for Expensifail account

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Expensifail account.
3. Open FAB.

Expected Result:

Track expense option will be present.

Actual Result:

Track expense option is not present in FAB for Expensifail account.
This issue is not reproducible on Gmail.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6641966_1729596849447.20241022_193129.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021855906845087708354
• Upwork Job ID: 1855906845087708354
• Last Price Increase: 2024-11-11

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Julesssss]

Occurring because the selfDM is not being detected. Checking to see if this is intentional.

[Julesssss]

Checking to see if reverting this PR resolves the issue.

[Julesssss]

Yeah, my revert PR resolves the bug.

[fabioh8010]

I made a Draft PR to migrate the remaining components again. @Julesssss @mountiny How can I test this? Is only possible to test with Expensifail accounts?

[mountiny]

Created an adhoc build and we can test internally

[melvin-bot]

@johncschuster, @Julesssss Huh... This is 4 days overdue. Who can take care of this?

[johncschuster]

How's this one going, @mountiny?

[fabioh8010]

Thanks for the help @ishpaul777, I was doing some testing now and was able to reproduce it with Gmail account. It only happens after login, which for some reason we are always having undefined in allReports in findSelfDMReportID(). After refreshing the page allReports is correctly populated and the Track Expense options appears again.

I will continue investigations

[fabioh8010]

I think I found a solution, testing on other platforms...

[fabioh8010]

Opened a new PR -> #52275

I'm going to close the other Draft one since my migrations are no longer necessary – all the remaining components were migrated.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021855906845087708354

[melvin-bot]

Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new.

[Pholenk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

FAB - Track expense option is not present in FAB for Expensifail account

What is the root cause of that problem?

The root cause is located on here:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 356 in 1223311

if (canUseCombinedTrackSubmit) {

and here:

App/src/libs/Permissions.ts

Line 32 in 1223311

function canUseCombinedTrackSubmit(): boolean {

I don't know why we have to determine it by checking whether the user id is equal to 0 after being modulated by 2.
Because of that user, with user id that equal to 0 after being modulated by 2, can not see the Track Expense button .

What changes do you think we should make in order to solve the problem?

We need to change this:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 356 in 1223311

if (canUseCombinedTrackSubmit) {

to be this:
if (canUseCombinedTrackSubmit && !!canUseAllBetas) {

simplescreenrecorder-2024-11-11_18.02.49.mp4

What alternative solutions did you explore? (Optional)

we need to change the logic stated in here if necessary:

App/src/libs/Permissions.ts

Line 32 in 1223311

function canUseCombinedTrackSubmit(): boolean {

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @Pholenk! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Pholenk]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01fb38b8e3c0567f3c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update selfDMReportID when opening/closing FAB #52275

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

• @brunovjk requires payment (Needs manual offer from BZ)

[melvin-bot]

@brunovjk @johncschuster @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[quinthar]

Fixed for me, thanks!