[HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.51-0
Reproducible in staging?: Can't check
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #49602
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch hybrid app.
2. Go to OD if the app is in ND.
3. Open menu.
4. Tap Trips.
5. Tap app back button.
6. Tap Try New Expensify.
7. Tap app back button.

Expected Result:

User is able to return to New Expensify from OD after opening Book travel page from OD.

Actual Result:

App is stuck at Book travel page after opening Trips from OD and then open Try New Expensify.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6639681_1729345161828.1729344665620_Screen_Recording_20241019_213058.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[IuliiaHerets]

We think that this bug might be related to #vip-travel

[carlosmiceli]

This is most likely the PR that caused it: #49602

[Beamanator]

FYI SWM is looking into this - https://expensify.slack.com/archives/C04878MDF34/p1729497719145869

[mateuuszzzzz]

Hi, I have an update.

On Android the issue is caused by lastVisitedPath from which we construct initial navigation state.
It is quite surprising that it is not reproducible on iOS, because it should be platform-agnostic.

I have a hypothesis that recently we had changes in code related to lastVisitedPath logic. This could change behaviour on Android, but this requires further verification.

I'm preparing PR with a fix. Also, I'm going to investigate why the behaviour is different on both platforms.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[yuwenmemon]

Closing: https://expensify.slack.com/archives/C9YU7BX5M/p1729557218232369?thread_ts=1729554748.866629&cid=C9YU7BX5M

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "[HybridApp] Allow classic experience users to use NewDot travel page" #51155

If no regressions arise, payment will be issued on 2024-10-29. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR:
• [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@carlosmiceli] Determine if we should create a regression test for this bug.
• [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "[HybridApp] Allow classic experience users to use NewDot travel page" #51155

If no regressions arise, payment will be issued on 2024-10-30. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR:
• [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@carlosmiceli] Determine if we should create a regression test for this bug.
• [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: