[HOLD for payment 2024-11-05] [$250] [HOLD for payment 2024-10-24] Speed up iOS builds

[roryabraham]

Coming off the hype train over in #49567

Problem

iOS builds take about 10 minutes for me on my M2 Mac

Solution

Investigate ways to speedup iOS builds.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849043155218614009
• Upwork Job ID: 1849043155218614009
• Last Price Increase: 2024-10-23

Issue Owner

Current Issue Owner: @

[roryabraham]

@Julesssss hopefully it's not too presumptive of me to assign you as babysitter.

@TMisiukiewicz @gedu et. all are going to look into this

[Julesssss]

Excellent, look forward to the investigation!

[TMisiukiewicz]

Hey, some of my first findings here:

1. For each development build we are including debug symbols for symbolicating stack traces, which is useful when analyzing crash logs. However, seems like it is only relevant for release builds to track crashes in production apps. I think we can disable it for development builds - it saves 10-20 seconds on each build for me.
2. Since we don't use Fullstory in debug mode, we can exclude "Run Fullstory Asset Uploader" from builds running on simulator - for me it's 5s improvement on each build. I think we could possibly skip Fullstory in development builds entirely to speed it up even more (just like on Android), however I am not sure how to do this properly since iOS SDK does not expose anything to do that. I need more investigation around it.

Some other stuff I tried:

1. Playing around Optimization Level - it's currently hard to say for me about any results, needs more investigation
2. Enabling ccache - my builds starts to fail, needs more investigation - might be related with too aggresive optimization level

Another thing i noticed was pretty high time of execution of custom shell script for copying xcframework GoogleAppMeasurement. (screen below). The problem is, this is happening for me only from time to time during the builds, so I am not sure if its impact on the build time is big. Anyway, it's a dependency of Firebase/Analytics and if I understand correctly, it is necessary when using ads in the app. It can be excluded by setting $RNFirebaseAnalyticsWithoutAdIdSupport = true in Podfile, then it's not used in a build anymore. Might be some caching issue on my side, so maybe it's worth building the app in xcode a few times by someone who haven't done any optimization tweaks before to confirm that.

[TMisiukiewicz]

Opened first PR excluding uploading assets to Fullstory in development #50633. It should save 30-50s on each build

[TMisiukiewicz]

Also opened #50634 to skip generating dSYM in development builds. For me it saves 8-15 seconds on each build.

With this 2 PRs, my cached builds went down from ~42s to ~15s. Also saves 30-60seconds for clean builds.

[TMisiukiewicz]

Tried one more thing today: passing --jobs param to xcodebuild. It specifies the maximum number of concurrent build operations. It defaults to amount of cores + 1 (so in my case it's 8+1). I increased it to 12, but haven't seen any improvement in build time, the average times for default and custom value were pretty similar

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] perf: skip building dSYM for iOS development build #50634

If no regressions arise, payment will be issued on 2024-10-24. 🎊

[shubham1206agra]

@roryabraham Please assign me here as reviewer

[Julesssss]

Hey @shubham1206agra I'll handle this as Rory is away.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849043155218614009

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Julesssss]

Hey @sakluger, assigning you for the payout which is due tomorrow

[sakluger]

Summarizing payment on this issue:

Contributor: @TMisiukiewicz - No payment due, contractor
Contributor+: @shubham1206agra $250, sent Upwork offer: https://www.upwork.com/nx/wm/offer/104560053

[shubham1206agra]

@sakluger Offer accepted

[sakluger]

Thanks! All paid.

[melvin-bot]

@sakluger @Julesssss Be sure to fill out the Contact List!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] perf: remove Fullstory Asset Uploader phase from iOS dev builds #50633

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)