[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Yellow color tones not applied for emoji

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @techievivek
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727840322244459

Action Performed:

1. Set yellow color as a color tone for emojis
2. Hover on a message and click on Add reaction > Select :thumpsup

Expected Result:

Emoji color tone shows in yellow

Actual Result:

But showing in different color

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[zfurtak]

Hello, this is cause by my recently merged PR and I would like to take of this issue (I work for swm agency)

[jasperhuangg]

@zfurtak Please fix the regression, thanks!

[jasperhuangg]

@zfurtak Are you actively looking into the fix for this issue?

[jasperhuangg]

cc @roryabraham, if they're not around, can you look into a fix for this since you reviewed that PR?

[roryabraham]

sure

[ishpaul777]

Bug is here

App/src/libs/EmojiUtils.ts

Line 465 in 8a35256

const emojiCodeWithSkinTone = emoji.types[preferredSkinTone];

if preferredSkinTone is -1 .at returns emoji.types[emoji.types.length -1], cleanest solution should be revert back to emoji.types[preferredSkinTone] or add condition for preferredSkinTone >= 0.

if (emoji.types && typeof preferredSkinTone === 'number' && preferredSkinTone >= 0) {
        const emojiCodeWithSkinTone = emoji.types.at(preferredSkinTone);

or

if (emoji.types && typeof preferredSkinTone === 'number') {
        const emojiCodeWithSkinTone = emoji.types[preferredSkinTone]

[jasperhuangg]

@ishpaul777 I already worked on a similar fix here and have a PR I'm testing for this already locally. Thanks for commenting.

[ishpaul777]

Nice, lmk just incase you need a C+ : )

[roryabraham]

Thanks for handling @jasperhuangg

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Yellow color tones not applied for emoji #50119

If no regressions arise, payment will be issued on 2024-10-10. 🎊

For reference, here are some details about the assignees on this issue:

• @zfurtak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jasperhuangg / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@jasperhuangg / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jasperhuangg / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@zfurtak] Determine if we should create a regression test for this bug.
• [@zfurtak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Yellow color tones not applied for emoji #50119

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @zfurtak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jasperhuangg / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@jasperhuangg / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jasperhuangg / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@zfurtak] Determine if we should create a regression test for this bug.
• [@zfurtak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: