[$250] Hybrid app - Loading skeleton when notification tapped and app is killed state

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1727449830031979

Action Performed:

1. Have a long chat with User B
2. As User A, access the chat on your device so it’s cached and kill the app
3. As User B, message User A
4. As User A, tap on the notification for the message.

Expected Result:

The full cached chat should be opened, potentially minus the most recent message.

Actual Result:

A skeleton page loads, indicating the app is reloading the chat from scratch rather than using the cache.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

screen-20240930-073210.mp4

Profile_trace_for_9.0.41-2.cpuprofile

logs-2024-09-30 14_32_20.691.txt

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844432440110156078
• Upwork Job ID: 1844432440110156078
• Last Price Increase: 2024-10-10

[melvin-bot]

Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[Beamanator]

Maybe we can make this Weekly since it's not reproducible yet?

[garrettmknight]

One possible fix to this (removing duplicate reconnectapp calls) is out, bumping to see if this is still happening here.

[garrettmknight]

Repro steps updated!

[melvin-bot]

Triggered auto assignment to @stitesExpensify (AutoAssignerNewDotQuality)

[garrettmknight]

@stitesExpensify reassigning since Alex is going to be OOO until Tuesday. Can you take a look? I'll try to grab logs from my repro in a minute.

[garrettmknight]

Logs/onyx state here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: do not show spinner if data is already there #51098

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @kirillzyusko does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

@kirillzyusko looks like @quinthar is still experiencing:

screen-20241028-132410.mp4

[melvin-bot]

@garrettmknight @eVoloshchak @kirillzyusko @stitesExpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@garrettmknight, @eVoloshchak, @kirillzyusko, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[garrettmknight]

Looks like a recent adhoc build is solving this! Let's keep it open till we've deployed and tested on prod, but I'll take over monitoring to keep an eye on the PR.

[garrettmknight]

Checking for an internal Hybrid App engineer to handle this.

[Julesssss]

Hey @garrettmknight, I took a quick look, and I think we should update the description and reproduction steps and downgrade the current priority.

I'm unable to reproduce the loading skeleton issue for iOS or Android with the app either background or killed. @muttmuure mentioned this occurring for Concierge email chats, I didn't test that specific case but if that is still occurring I don't think it should be critical and take priority over our other HybridApp tasks.

^ I misunderstood the bug. Still don't think it's critical but we can get this looked at soon

RPReplay_Final1730899818.MP4

screen-20241106-131344.mp4

[jnowakow]

I'm from Software Mansion and I'll work on this one

[jnowakow]

I found out that the problems are caused by this code:

App/src/pages/home/ReportScreen.tsx

Line 349 in bd880d1

const isLoading = isLoadingApp ?? (!reportIDFromRoute || (!isSidebarLoaded && !isInNarrowPaneModal) || PersonalDetailsUtils.isPersonalDetailsEmpty());

In ND isLoadingApp is set to true before the bootsplash is hidden and messages are shown correctly. While in hybrid app it takes more time to finish loading the app and thus both isLoadingApp and isSidebarLoaded equal to false when ReportScreen is shown causing the skeleton to show up. I don't know why openApp (function that sets isAppLoading to false) takes more time on hybrid. I have to figure out what is causing this behaviour.

[jnowakow]

Sorry, yesterday I worked shorter hours and didn't had time to answer at the end of the day. I found out that on the ND when opening the app there is no OpenApp call. Instead ReconnectApp is called. So there are two options. The easier option is to enforce hybrid app to wait until OpenApp call is finished and only then hide bootsplash. The other way is to investigate why OpenApp is called every and check if it's necessary.
For now I'll to check the second option

[Julesssss]

The easier option is to enforce hybrid app to wait until OpenApp call is finished and only then hide bootsplash.

That doesn't sound ideal if it delays users from entering the app. Do you think this problem might stop once we finish implementing the TTI changes? (boot and authenticate App in RN instead of yapl)

[jnowakow]

I'm not sure if this will help because it's not matter of booting RN but making http call. I'll investigate why in hybrid app ND always call openApp instead of reconnect.

[jnowakow]

Okey, soo...

I think the solution for bug is easy, we just don't need to call openApp every time. Only when the user open ND for the first time. It's good news.

The bad news is that it doesn't work because there is another bug 🥲

For some reason sometimes when ND is opened (and it's not first time) Onyx is completely empty. It's because OnyxDB, OnyxDB-wal and OnyxDB-shm are removed in the meantime.

Here are the reproduction steps:

• open hybrid app
• log in (ND opens if not open it manually)
• sign out and do not close the app
• sign in (ND opens)
• close app
• open app
• observe all chats load

Recording:

hybrid.bug.mp4