[$100] Android -Profile - Error Message Cut Off When Uploading Large Image to Profile

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: No, prod has another wrong behavior
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to Account Settings > Profile.
2. Upload a large image (>24MB).

Expected Result:

The error message should display fully when attempting to upload a large image to the profile.

Actual Result:

The error message is cut off when a large image is uploaded to the profile.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6609122_1726767885171.Recorder_19092024_171503.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836847837390067999
• Upwork Job ID: 1836847837390067999
• Last Price Increase: 2024-09-19

Issue Owner

Current Issue Owner: @fedirjh

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Prod behavior

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-09-19 19:13:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android -Profile - Error Message Cut Off When Uploading Large Image to Profile

What is the root cause of that problem?

We are not adding styles.w100 to the view below, and the container of AvatarWithImagePicker doesn't take full width

App/src/pages/settings/Profile/ProfilePage.tsx

Line 133 in 98dc643

<View style={[styles.pt3, styles.pb6, styles.alignSelfStart]}>

What changes do you think we should make in order to solve the problem?

Add styles.w100

What alternative solutions did you explore? (Optional)

Result

[allgandalf]

I guess this should be treated as a new bug, we found out about this during testing (slack convo here), we didn't act on this because the alignment of the error on small screen is not great and eventually decided to report it in our bugs channel

c.c. @rushatgabhane @dangrous

[grgia]

Removing deploy blocker label since this is on prod

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836847837390067999

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Upwork job price has been updated to $100

[Krishna2323]

@grgia, we are handling this issue here.

[melvin-bot]

@sonialiap, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

Let's put on hold for :

• fix: Profile - No error after uploading corrupted jpg for avatar, console error shows up. #49203

[melvin-bot]

@sonialiap, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[fedirjh]

PR that fixes this issue is ready to get merged.

[melvin-bot]

@sonialiap, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

PR is deployed to staging.

[melvin-bot]

@sonialiap @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sonialiap]

@fedirjh am I correct in that this is being handled in #49203 (review) which is a PR for #48707? So the payment for this would also be handled there, correct?

[melvin-bot]

@sonialiap, @fedirjh Eep! 4 days overdue now. Issues have feelings too...

[etCoderDysto]

@sonialiap This issue is fixed. I think we can close this one.

[sonialiap]

Thanks 👍