[HOLD FOR PAYMENT 9/26]Expense - Nothing happens when hitting Enter on amount page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.37-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Submit expense > Manual.
4. Enter amount.
5. Hit Enter.

Expected Result:

Enter key will proceed to next step.

Actual Result:

Nothing happens when hitting Enter on amount page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6607106_1726613695588.743766129871136314420240918_044316.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[luacmartins]

Pretty sure it came from this PR #49023 @suneox @alitoshmatov

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task title is overlapped by task arrow

What is the root cause of that problem?

The input has the role is CONST.ROLE.PRESENTATION and we don't exclude it here. It happens after this PR

App/src/components/Button/index.tsx

Line 152 in 448ca57

const shouldDisableEnterShortcut = useMemo(() => accessibilityRoles.includes(activeElementRole ?? ''), [activeElementRole]);

What changes do you think we should make in order to solve the problem?

We should return shouldDisableEnterShortcut as false if the activeElementRole is CONST.ROLE.PRESENTATION as we did in the past like the diff in this PR

const shouldDisableEnterShortcut = useMemo(() => accessibilityRoles.includes(activeElementRole ?? '') && activeElementRole !== CONST.ROLE.PRESENTATION, [activeElementRole]);

App/src/components/Button/index.tsx

Line 152 in 448ca57

const shouldDisableEnterShortcut = useMemo(() => accessibilityRoles.includes(activeElementRole ?? ''), [activeElementRole]);

OPTIONAL: We can exclude other roles if this role is not a pressable element.

What alternative solutions did you explore? (Optional)

NA

[nkdengineer]

@luacmartins This comes from this #49316.

[luacmartins]

Ah nice find. Are you available to work on a PR?

[nkdengineer]

@luacmartins Sure.

[nkdengineer]

@luacmartins The PR is ready.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

this was fixed but we forgot to remove the label I believe

[CortneyOfstad]

PR was deployed to production 4 days ago — updating the title!

[CortneyOfstad]

@nkdengineer — offer sent to you here in Upwork — please let me know once you accept and I'll get that paid ASAP. Thanks!

[nkdengineer]

@CortneyOfstad I accepted thanks

[CortneyOfstad]

Payment Summary

@nkdengineer — paid $250 via Upwork