[HOLD for Payment 2024-09-26][$250] [Search v2.2] - Chats - Report with error shows RBR next to checkbox in "In" list

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48275
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User B has only one workspace.

1. Go to staging.new.expensify.com
2. {User A] Send an invoice to User B.
3. [User B] Pay the invoice using Pay as a business option.
4. [User A] Go offline.
5. [User A] Send another invoice to User B in the same invoice room.
6. [User B] Delete the workspace.
7. [User A] Go online.
8. [User A] Click on the invoice preview that has RBR.
9. [User A] Go to Search > Chats.
10. [User A] Click Filters.
11. [User A] Click In.

Expected Result:

The invoice report with error should not have RBR next to the checkbox in "In" list.

Actual Result:

The invoice report with error has RBR next to the checkbox in "In" list.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601030_1726147500150.20240912_212055.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834357041213588001
• Upwork Job ID: 1834357041213588001
• Last Price Increase: 2024-09-12

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[luacmartins]

I can take this one since it's part of Search

[luacmartins]

@Kicu @289Adam289 if you're interested in working on a fix

[luacmartins]

I'm gonna demote this to NAB since it's a small issue

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The invoice report with error has RBR next to the checkbox in "In" list.

What is the root cause of that problem?

• The option data can have brickRoadIndicator because of:
  

  App/src/libs/OptionsListUtils.ts

  Line 743 in 6d70b10

  result.brickRoadIndicator = !isEmptyObject(result.allReportErrors) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';

• Then in BaseListItem component, we display danger icon if brickRoadIndicator is true:
  

  App/src/components/SelectionList/BaseListItem.tsx

  Lines 118 to 122 in 6d70b10

  	{!item.isSelected && !!item.brickRoadIndicator && (
  	<View style={[styles.alignItemsCenter, styles.justifyContentCenter]}>
  	<Icon
  	src={Expensicons.DotIndicator}
  	fill={item.brickRoadIndicator === CONST.BRICK_ROAD_INDICATOR_STATUS.INFO ? theme.iconSuccessFill : theme.danger}

What changes do you think we should make in order to solve the problem?

• We should introduce new param in BaseListItem named shouldDisplayRBR with default value is true and update:
  

  App/src/components/SelectionList/BaseListItem.tsx

  Line 118 in 6d70b10

  {!item.isSelected && !!item.brickRoadIndicator && (

                    {!item.isSelected && !!item.brickRoadIndicator && shouldDisplayRBR && (

• And in here:
  

  App/src/components/Search/SearchMultipleSelectionPicker.tsx

  Line 102 in 6d70b10

  <SelectionList

  
  pass shouldDisplayRBR={false}

What alternative solutions did you explore? (Optional)

[luacmartins]

@dominictb you're proposal looks good

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834357041213588001

[melvin-bot]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-26] according to #49427 production deploy checklist, confirmed in #49199 (comment)

cc @stephanieelliott

[melvin-bot]

@luacmartins, @stephanieelliott, @rayane-djouah, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dominictb]

@strepanier03 Good to pay.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @dominictb $250 - Upwork offer extended, please accept! https://www.upwork.com/nx/wm/offer/104189980
• Contributor+: @rayane-djouah$250 - Upwork offer extended, please accept! https://www.upwork.com/nx/wm/offer/104189994

Upwork job is here: https://www.upwork.com/jobs/~021834357041213588001

[dominictb]

@stephanieelliott Accepted

[rayane-djouah]

@stephanieelliott - Accepted!

[rayane-djouah]

@stephanieelliott kind reminder

[melvin-bot]

@luacmartins, @stephanieelliott, @rayane-djouah, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

All paid, thank you!