[HOLD for payment 2024-10-25] [HOLD for payment 2024-10-17] [$250] Sign in - Account settings long loading if navigate via public room link & login as new account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.30-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #48144

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log out
3. Go to this link https://staging.new.expensify.com/r/7075912447943023
4. Tap sign in
5. Enter credentials and log in as a new Gmail account

Expected Result:

Account settings loads fine

Actual Result:

Account settings long loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6595301_1725625415082.A_clear_anonymous_user_records_after_login.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836652520479378795
• Upwork Job ID: 1836652520479378795
• Last Price Increase: 2024-09-26
• Automatic offers:
• wildan-m | Contributor | 104259835

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bfitzexpensify]

Checking in on the other issue here

[bfitzexpensify]

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: confirming if the other PR caused this

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jjcoffee]

This doesn't appear to be related to #47806 - I can repro with the changes from there reverted. It's probably a BE issue as there are no personalDetails returned in the SignUpUser call.

[melvin-bot]

@bfitzexpensify, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VictoriaExpensify]

Thanks for confirming @jjcoffee . I'm going to move this to internal since this sounds like a BE issue

[VictoriaExpensify]

Not overdue

[trjExpensify]

Is this bug specific to the public rooms flow and on Android native only? If so, that was a project in #vip-vsb, and I think @jasperhuangg might be good to offer insight into that.

[bfitzexpensify]

Waiting on regressions to be resolved before issuing payment

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• (2nd) Fix long loading from public and redirect to last accessed report #50629

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @wildan-m requires payment automatic offer (Contributor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Payment to @wildan-m complete (paid out at $125 due to the regression).

@thesahindia, please complete the BZ checklist and I'll post the NewDot payment summary

[wildan-m]

@bfitzexpensify why there is penalty?

no 50% urgency bonus when we merge within 3 days and penalty also removed based on the announcement

https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1698191269281379?thread_ts=1698191269.281379&cid=C01GTK53T8Q

[bfitzexpensify]

@wildan-m we removed the time-based penalties that came from not merging a PR within 216 hours of assignment.

There was no change to the regression penalties, which dock 50% of the pay when a regression is caused.

[aldo-expensify]

There was no change to the regression penalties, which dock 50% of the pay when a regression is caused.

Does this apply if the same contributor fixed the regression here #50629 ?

Update: hmm I see now that the original PR was reverted and the @wildan-m put the new PR to fix without the regression. I have no idea how the penalties work and I'm just asking out of curiosity by the way :)

[bfitzexpensify]

This is what we say in the CONTRIBUTING.md:

Regressions
If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

• payments will be issued 7 days after all regressions are fixed (ie: deployed to production)
• a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue

The 168 hours (aka 7 days) will be measured by calculating the time between when the PR is merged, and when a bug is posted to the #expensify-bugs Slack channel.

So the penalty is applied regardless of who resolves the regression.

[bfitzexpensify]

Also bumping the BZ checklist @thesahindia - thank you!

[thesahindia]

I don't think we can pin point an exact PR that is responsible for this issue.

We should add a test case. Here are the steps for it:

1. Log out if you're signed in
2. Go to https://staging.new.expensify.com/r/7075912447943023
3. Click 'Sign in'
4. Enter a new email id and log in as a new account
5. Select any option and complete the flow
6. Verify that the loading is complete and the app is responsive.
7. Verify that you are at the initially opened report

[bfitzexpensify]

Payment summary:

@thesahindia due $125 for C+ work

[melvin-bot]

@lakchote @bfitzexpensify Be sure to fill out the Contact List!