Accounting-App proceeds to Netsuite Setup when trying to connect to Sage Intacct

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Log in to new dot with a new account and create a new workspace
2. Navigate to settings > workspace > More features > Enable accounting
3. Go to Accounting > Connect to Sage Intacct > Upgrade to Control > Got it
4. Now notice the RHP opened after upgrading the Workspace to control

Expected Result:

App proceeds to Sage Intacct Setup page

Actual Result:

App proceeds to Netsuite Setup page. User has to close RHP and connect to Sage Intacct again to proceed with Sage Intacct Setup.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6594968_1725597549531.2024-09-06_07_28_45.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting-App proceeds to Netsuite Setup when trying to connect to Sage Intacct

What is the root cause of that problem?

Offending PR #48419.

We passed the wrong route here

App/src/pages/workspace/accounting/utils.tsx

Line 243 in ec012fe

: ROUTES.POLICY_ACCOUNTING_NETSUITE_TOKEN_INPUT.getRoute(policyID),

It should be ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_PREREQUISITES.getRoute(policyID) as previously

What changes do you think we should make in order to solve the problem?

Replace this line by ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_PREREQUISITES.getRoute(policyID)

[nyomanjyotisa]

Ups my PR caused this, will fix now

[suneox]

@hoangzinh Thank you, this was our mistake after resolving conflicts and calling the incorrect function. I've verified the PR to resolve this issue

[trjExpensify]

Dope, all yours @youssef-lr.

[youssef-lr]

Asking for CP here https://expensify.slack.com/archives/C07J32337/p1725645245191609

[trjExpensify]

Adding you both, so it's clear who was involved in this issue for posterity. The PR was CP'd to staging and that checklist has now been deployed, so I'm going to close this out. Payment will be handled in the original issue accounting for the regression: #48269

Thanks ya'll!