Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #48440

Closed
github-actions bot opened this issue Sep 2, 2024 · 5 comments
Assignees

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

🚨 Failure Summary 🚨:

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named e2ePerformanceTests / Run E2E tests in AWS device farm.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

@roryabraham
Copy link
Contributor

weird, all we did here is remove effects and animations, which I would expect to make things simpler overall.

Looking at the logs, it seems unrelated.

@roryabraham roryabraham added Daily KSv2 and removed Hourly KSv2 labels Sep 2, 2024
@roryabraham
Copy link
Contributor

@struc
Copy link
Contributor

struc commented Sep 3, 2024

I think the issue is mainly here:

failed with error: Command failed: adb shell pm grant com.expensify.chat.e2edelta android.permission.POST_NOTIFICATIONS

Exception occurred while executing 'grant':
java.lang.IllegalArgumentException: Unknown permission: android.permission.POST_NOTIFICATIONS

As far as I remember this permission is only available on Android 33+, so older versions will not recognize the permission.

@kirillzyusko
Copy link
Contributor

@struc we know that and we handle it. Few lines below we print a message:

[Mon Sep 02 2024 22:57:58 GMT+0000 (Coordinated Universal Time)]  ⚠️  Failed to grant push notifications permissions. It might be due to the fact that push-notifications permission type is not supported on this OS version yet. Continue tests execution...

The problem was the fact that upgrade to RN 0.75 made "typing test" flaky and almost all runs were not successful. When we merged #48191 we fixed flakiness in delta builds, and thus we got a miracle chance that tests may pass (baseline was still flaky, but still there could be a chance). And that's exactly what we've got:

image

And our CI saw previous successful runs and associated the failure with a merged PR and created the issue. But changes from these PR don't affect tests. Tests were flaky and because of that we end up in this situation.

After a new release I believe all tests will become stable again and we will not have random failures 🤞

@kirillzyusko
Copy link
Contributor

I think the issue can be closed because e2e pipeline seems to be stable now!

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants