Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in – Unable to login via Magic link, Magic code expired appears #48378

Closed
2 of 6 tasks
IuliiaHerets opened this issue Aug 31, 2024 · 24 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4906568
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. In Sign in page enter new Expensify email
  3. Open email and copy Magic link
  4. Change it to staging and navigate to it in a new tab

Expected Result:

Abracadabra page opens. We have KI #44600

Actual Result:

Magic code expired appears

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6588552_1725081784278.magic_link.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 31, 2024
Copy link

melvin-bot bot commented Aug 31, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 31, 2024

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 31, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@ishpaul777
Copy link
Contributor

Can't reproduce, tried multiple times

Screen.Recording.2024-09-02.at.2.10.02.AM.mov

@danieldoglas
Copy link
Contributor

@IuliiaHerets can you try this one again? Looks like you were logged in on a tab already on your video, so maybe that's why?

@danieldoglas danieldoglas removed the DeployBlocker Indicates it should block deploying the API label Sep 2, 2024
@danieldoglas
Copy link
Contributor

not a deploy blocker for the API since it doesn't happen in production

@danieldoglas danieldoglas added Weekly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 2, 2024
@IuliiaHerets
Copy link
Author

@danieldoglas Issue is still reproducible, build - v9.0.27-0

Screenrecorder-2024-09-02-20-39-56-247.mp4

@ishpaul777
Copy link
Contributor

We are awaiting proposals

@danieldoglas
Copy link
Contributor

@ishpaul777 are you able to reproduce this now?

@ishpaul777
Copy link
Contributor

ishpaul777 commented Sep 4, 2024

Lol no, my instinct kicked in and i wrote "awaiting proposal", what i mean is waiting reliable steps to repro

Screen.Recording.2024-09-05.at.1.38.57.AM.mov

@deetergp
Copy link
Contributor

deetergp commented Sep 5, 2024

I just ran into this on staging by sending an Invoice from one user to an email address that does not yet have an Expensify account. I was able to reproduce a second time by sending to another email without an account.

@danieldoglas
Copy link
Contributor

nice, thanks for that @deetergp . @ishpaul777 can you try those steps and confirm it still fails? Then we can open it for external proposals.

@ishpaul777
Copy link
Contributor

Seems we have a existing issue that we can not send a invoice to any user.

https://expensify.slack.com/archives/C01GTK53T8Q/p1725613866403789

Copy link

melvin-bot bot commented Sep 14, 2024

@danieldoglas @muttmuure @ishpaul777 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Sep 16, 2024

still not able to reproduce the issue, i see theres draft PR that may fix this issue #48899

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 24, 2024
@ishpaul777
Copy link
Contributor

Same as ^

@melvin-bot melvin-bot bot removed the Overdue label Sep 24, 2024
@danieldoglas
Copy link
Contributor

K, I'll close this issue for now.

@IuliiaHerets
Copy link
Author

@danieldoglas QA team still can repro the issue, build - v9.0.46-2

Recording.4235.mp4

@IuliiaHerets IuliiaHerets reopened this Oct 8, 2024
@danieldoglas
Copy link
Contributor

can you try to not delete the https:// part of the URL? I think the issue is that there's a redirect happening from HTTP > https and the router is somehow not figuring out the whole path string.

It works normally for me in the same scenario:

Screen.Recording.2024-10-08.at.11.53.14.mov

@danieldoglas danieldoglas added the Reviewing Has a PR in review label Oct 13, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

This issue has not been updated in over 15 days. @danieldoglas, @muttmuure, @ishpaul777 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@ishpaul777
Copy link
Contributor

@IuliiaHerets please help retest, i can't reproduce

@IuliiaHerets
Copy link
Author

@ishpaul777 Tester can't reproduce this issue in the latest build (v9.0.60-0)

bandicam.2024-11-12.12-09-25-070.mp4

@ishpaul777
Copy link
Contributor

@muttmuure/ @danieldoglas Should we close this ?

@danieldoglas
Copy link
Contributor

Yep, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants