mWeb - Group chat - After removing member, admin leaving group chat app crashes

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4895730
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab -- start chat
3. Select a user and create a group
4. Tap header -- members
5. Long press the members and select "remove" member
6. Navigate back to "details" page and tap "Leave"

Expected Result:

After removing member, admin leaving group chat app must not crash.

Actual Result:

After removing member, admin leaving group chat app crashes.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2708_2.txt

Bug6583856_1724733050917.sh.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After removing member, admin leaving group chat app crashes.

What is the root cause of that problem?

draftMessage here somehow turns to empty object {}:

App/src/pages/home/report/ReportActionItem.tsx

Lines 182 to 187 in 4822d91

	const [draftMessage] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${originalReportID}`, {
	selector: (draftMessagesForReport) => {
	const matchingDraftMessage = draftMessagesForReport?.[action.reportActionID];
	return typeof matchingDraftMessage === 'string' ? matchingDraftMessage : matchingDraftMessage?.message;
	},
	});

That fails the line here even though we have a safeguard for undefined value:

App/src/libs/EmojiUtils.ts

Line 288 in 1ea6781

const parsedEmojis = text.match(CONST.REGEX.EMOJIS);

App/src/libs/EmojiUtils.ts

Lines 283 to 285 in 1ea6781

	if (!text) {
	return [];
	}

What changes do you think we should make in order to solve the problem?

Check type of text as string instead of just undefined value:

App/src/libs/EmojiUtils.ts

Lines 283 to 285 in 1ea6781

	if (!text) {
	return [];
	}

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when leaving a group chat as the last member.

What is the root cause of that problem?

The error comes when we try to extract the emoji from the draft message here because the draftMessage is an empty object instead of a string, so {}.match will crash.

App/src/pages/home/report/ReportActionItemMessageEdit.tsx

Lines 103 to 106 in 9ddca5c

	const [draft, setDraft] = useState(() => {
	if (draftMessage) {
	emojisPresentBefore.current = EmojiUtils.extractEmojis(draftMessage);
	}

App/src/libs/EmojiUtils.ts

Lines 282 to 288 in 9ddca5c

	function extractEmojis(text: string): Emoji[] {
	if (!text) {
	return [];
	}
	// Parse Emojis including skin tones - Eg: ['👩🏻', '👩🏻', '👩🏼', '👩🏻', '👩🏼', '👩']
	const parsedEmojis = text.match(CONST.REGEX.EMOJIS);

The reason it's an empty object is that after we leave the group, the report is deleted, and report.reportID becomes an empty string because we default it to an empty string,

App/src/pages/home/ReportScreen.tsx

Lines 169 to 172 in 9ddca5c

	const report = useMemo(
	(): OnyxTypes.Report => ({
	lastReadTime: reportOnyx?.lastReadTime,
	reportID: reportOnyx?.reportID ?? '',

so, when we try to fetch the draft, it fetches the onyx collection (reportActionsDrafts_) which is an empty object because we don't have any draft.

App/src/pages/home/report/ReportActionItem.tsx

Lines 181 to 187 in 9ddca5c

	const originalReportID = useMemo(() => ReportUtils.getOriginalReportID(report.reportID, action) ?? '-1', [report.reportID, action]);
	const [draftMessage] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${originalReportID}`, {
	selector: (draftMessagesForReport) => {
	const matchingDraftMessage = draftMessagesForReport?.[action.reportActionID];
	return typeof matchingDraftMessage === 'string' ? matchingDraftMessage : matchingDraftMessage?.message;
	},
	});

What changes do you think we should make in order to solve the problem?

Use || instead of ?? so it will fallback to -1 if it's an empty string.

App/src/pages/home/report/ReportActionItem.tsx

Lines 181 to 182 in 9ddca5c

	const originalReportID = useMemo(() => ReportUtils.getOriginalReportID(report.reportID, action) ?? '-1', [report.reportID, action]);
	const [draftMessage] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${originalReportID}`, {

OR

Don't default to an empty string

App/src/pages/home/ReportScreen.tsx

Lines 169 to 172 in 9ddca5c

	const report = useMemo(
	(): OnyxTypes.Report => ({
	lastReadTime: reportOnyx?.lastReadTime,
	reportID: reportOnyx?.reportID ?? '',

[cristipaval]

@bernhardoj could you also find the offending PR?

[bernhardoj]

It happens after #47866

[bernhardoj]

PR is ready!

[puneetlath]

@cristipaval confirmed it's fixed on staging. Demoting.

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @cristipaval, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[puneetlath]

Does anyone need to be paid out here?

[bernhardoj]

Yes, I think it's only me

[puneetlath]

Is it this PR? #48096

Looks like @hungvu193 reviewed that?

[hungvu193]

Is it this PR? #48096

Looks like @hungvu193 reviewed that?

Ah yes but it's regression so no payment needed for me

[puneetlath]

Ok thanks for the clarifications.

Payment summary:

• $250 - C - @bernhardoj - to be paid via NewDot

[bernhardoj]

Requested in ND

[JmillsExpensify]

$250 approved for @bernhardoj