Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] Improve developer experience around react-compiler #48066

Closed
6 tasks done
Kicu opened this issue Aug 27, 2024 · 12 comments
Closed
6 tasks done

[$125] Improve developer experience around react-compiler #48066

Kicu opened this issue Aug 27, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@Kicu
Copy link
Contributor

Kicu commented Aug 27, 2024

Version Number:
Reproducible in staging?: -
Reproducible in production?: -
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

This is purely a developer experience issue.

I have recently spent 1+ hours trying to fix an issue with react-compiler on one of my PRs. I think this may happen in future for more people and I wanted to add some tweaks to our code to improve this experience.

Here's what I would like to do:

I can have a PR ready very soon with these

CC @kirillzyusko

Action Performed:

N/A

Expected Result:

N/A

Actual Result:

N/A

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014befe13a62da3c50
  • Upwork Job ID: 1828579678211382500
  • Last Price Increase: 2024-08-28
Issue OwnerCurrent Issue Owner: @
@Kicu Kicu added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 27, 2024
@mallenexpensify mallenexpensify added the NewFeature Something to build that is a new item. label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Current assignee @mallenexpensify is eligible for the NewFeature assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Aug 27, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014befe13a62da3c50

@melvin-bot melvin-bot bot changed the title Improve developer experience around react-compiler [$250] Improve developer experience around react-compiler Aug 27, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 27, 2024
@mallenexpensify mallenexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024
@mallenexpensify
Copy link
Contributor

Don't think we need ya here @shawnborton , sorry. I added NewFeature to create an Upwork job for @rayane-djouah .

@rayane-djouah
Copy link
Contributor

@mallenexpensify The reward can be reduced to $125 according to the process, as PR doesn't require app testing.

@mountiny mountiny changed the title [$250] Improve developer experience around react-compiler [$125] Improve developer experience around react-compiler Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Upwork job price has been updated to $125

@mallenexpensify
Copy link
Contributor

@rayane-djouah can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~014befe13a62da3c50

@rayane-djouah
Copy link
Contributor

rayane-djouah commented Aug 30, 2024

@mallenexpensify Accepted! Thanks!

@mallenexpensify
Copy link
Contributor

Contributor+: @rayane-djouah paid $125 via Upwork

Don't think a regression test is needed here, plz comment if anyone disagrees and I'll reopen. And/or, @Kicu , if documentation needs to be updated anywhere. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants