Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb/Safari - Chat - Nothing happens when "Add attachment" option is tapped #47876

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 22, 2024 · 15 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 22, 2024

If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributimWeb - Chat - Nothing happens when "Add attachment" option is tappedcom to request to join our Slack channel!


Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4887449
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: issue seems to only affect mWeb on iOS/Safari

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Go to any chat
  4. Tap on the "+" button on compose box
  5. Select "Add attachment"

Expected Result:

The options menu to select an attachment should be displayed

Actual Result:

Nothing happens when "Add attachment" option is tapped

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6579532_1724350898451.Rpreplay_Final1724349613.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 22, 2024
Copy link

melvin-bot bot commented Aug 22, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 22, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 22, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 22, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

Production:

241111.mp4

@arosiclair
Copy link
Contributor

Reproduced with the latest changes in dev.

@arosiclair
Copy link
Contributor

Reverting #47341 fixes the issue

@arosiclair
Copy link
Contributor

Pinged @zfurtak to take a look here

@arosiclair
Copy link
Contributor

Revert is prepped here. Giving @zfurtak a chance to respond before moving forward.

@war-in
Copy link
Contributor

war-in commented Aug 23, 2024

@arosiclair FYI @zfurtak will respond on Monday (she is OOO this week). Feel free to revert the PR for now and we will handle reported bugs next week 🙏

Copy link

melvin-bot bot commented Aug 23, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@techievivek
Copy link
Contributor

techievivek commented Aug 23, 2024

Let's proceed with the revert since there are other blockers linked to the above PR. I've already pinged the app deployers in Slack to see if anyone is available to help with the CP: https://expensify.slack.com/archives/C07J32337/p1724404593705399

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 23, 2024
@fedirjh fedirjh mentioned this issue Aug 23, 2024
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 23, 2024
@arosiclair
Copy link
Contributor

Revert fixed it!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 26, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 3, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants