Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] Create OpenCardDetailsPage api command #47231

Closed
mountiny opened this issue Aug 12, 2024 · 11 comments
Closed

[Workspace Feeds] Create OpenCardDetailsPage api command #47231

mountiny opened this issue Aug 12, 2024 · 11 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

For the Workspace feeds project, we need to create a new command that will load the necessary details for the card when the card details page is opened
image

We need to load the classic details for a card including the availableSpend which is not returned for the list of all cards so we need to fetch it with the details.

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Aug 12, 2024
@mountiny mountiny self-assigned this Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 12, 2024
@mountiny mountiny moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Aug 12, 2024
@mountiny
Copy link
Contributor Author

cc @VickyStash for visibility this is the command for the card details page.

it takes authtoken and cardID as params

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@mountiny
Copy link
Contributor Author

Hello Viktoryia

@mountiny
Copy link
Contributor Author

read command OpenCardDetailsPage

Params:

  • string authToken
  • number cardID

Returns:

  • cards__Expensify Card with that one card formatted as you can see in Card.ts (including nameValuePairs, availableSpend, domainName)

@VickyStash
Copy link
Contributor

Updates:

  • I've prepared a Draft PR with OpenCardDetailsPage API call integration and follow-ups from another PR. I'll finalize it when API updates are deployed.

@VickyStash
Copy link
Contributor

@mountiny The OpenCardDetailsPage works as expected, thank you!

I've started to test the loading of the Card details page, and I have several questions:

  1. Should I show the loading indicator on the Card details page while OpenCardDetailsPage is executing?
  2. When the user updates the card limit, it affects the card's remaining limit (availableSpend) as well. Should I optimistically update the availableSpend value in this case, or should I show the loading on the Card details page instead while the update command is taking place?

@mountiny
Copy link
Contributor Author

Should I show the loading indicator on the Card details page while OpenCardDetailsPage is executing?

I will bring this to slack

When the user updates the card limit, it affects the card's remaining limit (availableSpend) as well. Should I optimistically update the availableSpend value in this case, or should I show the loading on the Card details page instead while the update command is taking place?

Lets try to update this optimistically

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 14, 2024
@VickyStash
Copy link
Contributor

The PR with OpenCardDetailsPage API call integration is open for the review

@trjExpensify
Copy link
Contributor

Any reason this issue is still open?

@mountiny
Copy link
Contributor Author

I dont think so

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants