Report fields - App crashes when disabling/enabling list values via checkbox & dropdown button

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #46938
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Report fields
3. Click Add field
4. Select List from Type
5. Go to List values and add a few list values
6. Long press on the list value > Select.
7. Tap on the dropdown.
8. Tap Disable.

Expected Result:

App will not crash.

Actual Result:

App crashes when disabling/enabling list values via checkbox and dropdown button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6569740_1723463950805.ScreenRecording_08-12-2024_19-53-26_1.1.mp4

Bug6569740_1723464002972!staging.new.expensify.com-1723463652050.txt

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #wave-control.

[izarutskaya]

Production

Screen_Recording_20240812_154622_New.Expensify.mp4

[mountiny]

cc @nkdengineer @jasperhuangg @jjcoffee from the linked PR

[nkdengineer]

Checking this now.

[nkdengineer]

@mountiny This comes from this PR. When we disable all values, the options becomes an empty array. Then the App crashes here

App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx

Line 260 in 4ef1202

options={options}

App/src/components/ButtonWithDropdownMenu/index.tsx

Line 53 in 4ef1202

const selectedItem = options[selectedItemIndex] || options[0];

[mountiny]

@Krishna2323 @mananjadhav are you able to handle this?

[Krishna2323]

Checking...

[Krishna2323]

Confirmed it is coming from my PR, trying to find a solution and will raise PR asap.

[carlosmiceli]

@Krishna2323 great!

@mountiny do you wanna take over this one since you have more context and already engaged in the conversation?

[Beamanator]

Taking over to move deploy forward :D

[Beamanator]

@allroundexperts will be reviewing @Krishna2323 's PR - #47244

[Beamanator]

PR merged, working on CP

[Beamanator]

CP'd, asking for test on staging

[Beamanator]

Working well on staging!

[mountiny]

Thanks everyone 🙇

[melvin-bot]

@Beamanator, @twisterdotcom, @allroundexperts, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Beamanator]

@twisterdotcom i believe @allroundexperts needs payment for C+ for #47244 - but maybe only once the fix has been on prod for a week?

[twisterdotcom]

I think it has now been on prod for a week? Deploy was on the 12th: #47219

[twisterdotcom]

Payment Summary:

• @allroundexperts paid $250 via NewDot requests (C+)

[JmillsExpensify]

$250 approved for @allroundexperts