Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 26th August] [$250] Bump Onyx to 2.0.64 #47044

Closed
kacper-mikolajczak opened this issue Aug 8, 2024 · 10 comments
Closed

[Awaiting Payment 26th August] [$250] Bump Onyx to 2.0.64 #47044

kacper-mikolajczak opened this issue Aug 8, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kacper-mikolajczak
Copy link
Contributor

Details

After recent Onyx improvements, we can update library to take advantage of them.

@ZhenjaHorbach
Copy link
Contributor

@mountiny
Can you assign me here please?

@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 12, 2024
@trjExpensify
Copy link
Contributor

Awaiting a regression period here like normal, right?

@mountiny
Copy link
Contributor

Yes

@ZhenjaHorbach
Copy link
Contributor

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

Performance issue

  • [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

  • [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

  • [@ZhenjaHorbach] Determine if we should create a regression test for this bug.

NA

  • [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I'm not sure we need tests for performance issues

@ZhenjaHorbach
Copy link
Contributor

@trjExpensify
Following this comment PR was deployed to prod August 13
So everything is ready for payment !

@trjExpensify trjExpensify added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Aug 26, 2024
@trjExpensify
Copy link
Contributor

Payment summary as follows:

Offer sent!

@trjExpensify trjExpensify changed the title Bump Onyx to 2.0.64 [Awaiting Payment 26th August] [$250] Bump Onyx to 2.0.64 Aug 26, 2024

This comment was marked as off-topic.

@ZhenjaHorbach
Copy link
Contributor

Payment summary as follows:

Offer sent!

The offer was accepted !
Thanks

@trjExpensify
Copy link
Contributor

Awesome, paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants