[HOLD for payment 2024-08-13] [HOLD for payment 2024-08-09] [$250] Expense- The number of Expense Request is not updated in the Report Conversation preview

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.15-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4796963
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open https://staging.new.expensify.com/.
2. Log in with your HT account
3. Create WS
4. Navigate to the WS room
5. Send 3 manual Expense Requests to the room

Expected Result:

When a new expense is added, the Expense Request quantity should immediately update in the Report Conversation preview

Actual Result:

The number of Expense Request is not updated in the Report Conversation preview.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6558736_1722472024060.Recording__33.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015476f4ee9e9cc44e
• Upwork Job ID: 1819064522910596934
• Last Price Increase: 2024-08-01

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The number of Expense Request is not updated in the Report Conversation preview

What is the root cause of that problem?

that the useMemo hook used to calculate the allTransactions data only depends on the iouReportID. As a result, the calculation is only triggered when the iouReportID changes, but not when the underlying transactions data changes.

App/src/components/ReportActionItem/ReportPreview.tsx

Line 125 in 3666caa

const allTransactions = useMemo(() => TransactionUtils.getAllReportTransactions(iouReportID), [iouReportID]);

What changes do you think we should make in order to solve the problem?

Include transactions in the useMemo dependency array to re-triggered whenever the transactions data changes

const allTransactions = useMemo(() => TransactionUtils.getAllReportTransactions(iouReportID), [iouReportID, transactions]);

What alternative solutions did you explore? (Optional)

[chiragsalian]

Removing web-e blocker label. Reasoning here.

[grgia]

#46500

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015476f4ee9e9cc44e

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[grgia]

Thanks for the solution @nyomanjyotisa, I've opened a PR here because it is a deploy blocker. Can you confirm a fair pay out for solution @kevinksullivan

[roryabraham]

fix CP'd, requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1722540773455279

[isagoico]

I'm not able to reproduce in the latest version v9.0.15-9 in staging (Chrome/Web):

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Deploy Blocker Fix - Update Expense Preview #46681

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Deploy Blocker Fix - Update Expense Preview #46681

If no regressions arise, payment will be issued on 2024-08-13. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ishpaul777]

This is good to close not payment necessary as this was a regression