-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font size broken after typing single emoji #46368
Comments
Triggered auto assignment to @yuwenmemon ( |
Triggered auto assignment to @trjExpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
I can reproduce the issue by inserting two emojis (the emojis will appear in large size), right-clicking on composer -> However, this is already fixed in the newer version of react-native-live-markdown. It is fixed by this PR. We just need to wait for the version update of react-native-live-markdown in the App. |
Yes, we are currently working on a few changes related to Emoji sizing. All of such small issues should be covered. |
It seems like we're already handling this issue here and since it's not reliably reproducible and this doesn't break any functionality, I'll demote it to NAB. |
Oh interesting, so do we need to hold on Expensify/react-native-live-markdown#374 (comment)? Any idea when that will get deployed? |
We can close this as PR was reverted. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722105553316819
Action Performed:
Expected Result:
Text should appear in normal size
Actual Result:
Text appears in larger font size
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: