Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size broken after typing single emoji #46368

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 27, 2024 · 9 comments
Closed
1 of 6 tasks

Font size broken after typing single emoji #46368

m-natarajan opened this issue Jul 27, 2024 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722105553316819

Action Performed:

  1. Type a single emoji
  2. Delete it
  3. Start typing with regular text

Expected Result:

Text should appear in normal size

Actual Result:

Text appears in larger font size

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 27, 2024
Copy link

melvin-bot bot commented Jul 27, 2024

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 27, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 27, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label Jul 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot removed the Hourly KSv2 label Jul 27, 2024
@m-natarajan m-natarajan added the Needs Reproduction Reproducible steps needed label Jul 27, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@tsa321
Copy link
Contributor

tsa321 commented Jul 29, 2024

I can reproduce the issue by inserting two emojis (the emojis will appear in large size), right-clicking on composer -> select all, and then typing text. The text size will become larger.

However, this is already fixed in the newer version of react-native-live-markdown. It is fixed by this PR. We just need to wait for the version update of react-native-live-markdown in the App.

@parasharrajat
Copy link
Member

Yes, we are currently working on a few changes related to Emoji sizing. All of such small issues should be covered.

@luacmartins
Copy link
Contributor

It seems like we're already handling this issue here and since it's not reliably reproducible and this doesn't break any functionality, I'll demote it to NAB.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Jul 29, 2024
@trjExpensify
Copy link
Contributor

Oh interesting, so do we need to hold on Expensify/react-native-live-markdown#374 (comment)? Any idea when that will get deployed?

@parasharrajat
Copy link
Member

We can close this as PR was reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

7 participants