[HOLD for payment 2024-08-09] [$250] Workspace - App back button overlaps with the status bar on not here page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Create a new workspace.
3. Go to Workspace settings > More features > Report fields.
4. Toggle on Report fields and tap Upgrade to upgrade to Control plan.
5. Go to Troubleshoot > Clear cache and restart > Reset and refresh.
6. Go to LHN and check that #admins room is present.
7. Delete the workspace.
8. Go to the now archieved #admins room.
9. Tap on the "here" link.

Expected Result:

App back button will not overlap with the status bar on not here page.

Actual Result:

App back button overlaps with the status bar on not here page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552399_1721897123593.ScreenRecording_07-25-2024_16-40-55_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014856468550d7e9c5
• Upwork Job ID: 1816573450502248380
• Last Price Increase: 2024-07-25

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[Julesssss]

Go to Troubleshoot > Clear cache and restart > Reset and refresh.

Providing this is a necessary step this should not be treated as a blocker. Removing the label.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App back button overlaps when accessing not found workspace.

What is the root cause of that problem?

The workspace more features page is wrapped with AccessOrNotFoundWrapper. If shouldShowFullScreenFallback, it will uses FullPageNotFoundView without a ScreenWrapper.

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 89 to 105 in 2dd7654

	function PageNotFoundFallback({policyID, shouldShowFullScreenFallback, fullPageNotFoundViewProps}: PageNotFoundFallbackProps) {
	return shouldShowFullScreenFallback ? (
	<FullPageNotFoundView
	shouldShow
	onBackButtonPress={() => Navigation.dismissModal()}
	shouldForceFullScreen
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...fullPageNotFoundViewProps}
	/>
	) : (
	<NotFoundPage
	onBackButtonPress={() => Navigation.goBack(policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...fullPageNotFoundViewProps}
	/>
	);
	}

ScreenWrapper adds a safe padding inset, specifically for native, so without ScreenWrapper, the header overlaps with the status bar. shouldShowFullScreenFallback is true if the policy is not accessible.

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 158 in 2dd7654

shouldShowFullScreenFallback={!isFeatureEnabled || isPolicyNotAccessible}

It's updated at #41665. Previously, we only used full screen not found for disabled feature, so the issue is actually not new but has already been there. Also, no need to do the troubleshoot clear cache and restart, just access any not found workspace.

What changes do you think we should make in order to solve the problem?

Wrap the FullPageNotFoundView with a ScreenWrapper,

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 89 to 104 in 2dd7654

	function PageNotFoundFallback({policyID, shouldShowFullScreenFallback, fullPageNotFoundViewProps}: PageNotFoundFallbackProps) {
	return shouldShowFullScreenFallback ? (
	<FullPageNotFoundView
	shouldShow
	onBackButtonPress={() => Navigation.dismissModal()}
	shouldForceFullScreen
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...fullPageNotFoundViewProps}
	/>
	) : (
	<NotFoundPage
	onBackButtonPress={() => Navigation.goBack(policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...fullPageNotFoundViewProps}
	/>
	);

OR

Just use NotFoundPage. NotFoundPage has ScreenWrapper in it.

App/src/pages/ErrorPage/NotFoundPage.tsx

Lines 11 to 21 in 2dd7654

	function NotFoundPage({onBackButtonPress, ...fullPageNotFoundViewProps}: NotFoundPageProps) {
	return (
	<ScreenWrapper testID={NotFoundPage.displayName}>
	<FullPageNotFoundView
	shouldShow
	onBackButtonPress={onBackButtonPress}
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...fullPageNotFoundViewProps}
	/>
	</ScreenWrapper>
	);

We just need to pass the necessary props to it conditionally when shouldShowFullScreenFallback is true.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014856468550d7e9c5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

@Julesssss, @rushatgabhane, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[bernhardoj]

PR is ready

cc: @rushatgabhane

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix back button overlaps with status bar in workspace not found page #46479

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

Hey @bernhardoj @rushatgabhane seems like #46646 may be a regression -- can you take a look?

[rushatgabhane]

hey, it looks like it's unrelated to the PR

[stephanieelliott]

Got it! Ok thanks for checking.

[bernhardoj]

Requested in ND for the payment today.

[JmillsExpensify]

Can I get a payment summary?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1816573450502248380/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @bernhardoj $250 - please request via NewDot
• Contributor+: @rushatgabhane - $250 - please request via NewDot

Upwork job is here: https://www.upwork.com/jobs/~014856468550d7e9c5

[JmillsExpensify]

$250 approved for each of @bernhardoj and @rushatgabhane