Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deploy confirmation step on web #46156

Closed
roryabraham opened this issue Jul 25, 2024 · 5 comments
Closed

Add a deploy confirmation step on web #46156

roryabraham opened this issue Jul 25, 2024 · 5 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement.

Comments

@roryabraham
Copy link
Contributor

Problem

Coming from here, we went a few days without noticing production deploys were broken.

Solution

We've addressed the root cause and I created rhysd/actionlint#440 to try and prevent any similar type of error in the future.

However, let's also add an automated check that just confirms that the deploy completed as we expect, at least on web. In order to do this, we can just download the version.json file hosted on staging and/or production and verify that it matches what we expect after the deploy is done.

@roryabraham roryabraham added Weekly KSv2 Improvement Item broken or needs improvement. labels Jul 25, 2024
@roryabraham roryabraham self-assigned this Jul 25, 2024
@roryabraham roryabraham changed the title Add a deploy confirmation step Add a deploy confirmation step on web Jul 25, 2024
@roryabraham
Copy link
Contributor Author

Thinking about this some more, even if we had this in place it would not have caught the error we had. Because the URL we were using was wrong for the upload, there's no reason to think it would've been right on the verification step. So I'm going to just close this actually.

@roryabraham roryabraham closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2024
@roryabraham
Copy link
Contributor Author

if we wanted to do this, I think we'd want it to be a manual check. Not sure how we'd fit that in as a deployer responsibility though

@roryabraham
Copy link
Contributor Author

we decided to add this after all

@roryabraham roryabraham reopened this Jul 25, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 29, 2024
@melvin-bot melvin-bot bot changed the title Add a deploy confirmation step on web [HOLD for payment 2024-08-05] Add a deploy confirmation step on web Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-05. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 5, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@roryabraham roryabraham changed the title [HOLD for payment 2024-08-05] Add a deploy confirmation step on web Add a deploy confirmation step on web Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

1 participant