Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] Enable Firebase performance logging #46113

Closed
TMisiukiewicz opened this issue Jul 24, 2024 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@TMisiukiewicz
Copy link
Contributor

TMisiukiewicz commented Jul 24, 2024

Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1721655178311639

Problem

Our current performance/reliability focus is on app behavior for specific accounts, but we are missing the broader view of performance trends over time for a wider audience. Additionally, CK cannot access Grafana dashboard, so we don't know how performance data behaves across the app for end users.

Solution

Let's enable capturing performance data in Firebase. This setup would automatically collect session data from a small number of users, including CPU and memory usage, network requests, etc. We could extend this by adding information about an account, such as the amount of personal details and reports on the account. This would allow us to link resource usage with the amount of data.

We could further enhance this by tracing screen rendering to gather information about slow rendering and frozen frames.

With all this data, we can identify and fix performance issues before they affect a significant portion of users, and prioritize features and fixes based on real user data.

Issue OwnerCurrent Issue Owner: @sakluger
@TMisiukiewicz TMisiukiewicz added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jul 24, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@cristipaval cristipaval added the Reviewing Has a PR in review label Jul 25, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 26, 2024
@marcaaron marcaaron assigned marcaaron and unassigned cristipaval Jul 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 29, 2024
@melvin-bot melvin-bot bot changed the title Enable Firebase performance logging [HOLD for payment 2024-08-05] Enable Firebase performance logging Jul 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-05. 🎊

Copy link

melvin-bot bot commented Jul 29, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
  • [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@marcaaron] Determine if we should create a regression test for this bug.
  • [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@marcaaron
Copy link
Contributor

This was new feature rather than a bug and no payments are needed here so gonna just close it out.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 31, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-08-05] Enable Firebase performance logging [HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] Enable Firebase performance logging Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-07. 🎊

Copy link

melvin-bot bot commented Jul 31, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
  • [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@marcaaron] Determine if we should create a regression test for this bug.
  • [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants