-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAID] [$250] [Search v2.1] [App] Create From and To filter #46035
Comments
Triggered auto assignment to @bfitzexpensify ( |
@luacmartins, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
hello, I would like to work on this filter next, since my other PRs are almost done. Please assign me |
Job added to Upwork: https://www.upwork.com/jobs/~010c6f76a94b99da45 |
Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new. |
whoever knows if from + to filters should be allow multi selection of people? And I'm assuming it should look the same as our other people pickers? |
@Kicu yes, it should allow multi-select. The filters that allow multi-select can be found here in the doc |
and yes, it should look like the current contact selector |
@CherylWalsh - We need a copy to replace the "Assign it to me" for the self DM option section title for these two pages: We are using a similar picker to the assignee page picker: |
@CherylWalsh actually, we don't need the copy since we decided to remove the sections altogether. |
PR is merged |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
PR deployed to production yesterday #46962 (comment) |
@Kicu, @luacmartins, @bfitzexpensify, @rayane-djouah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Note The production deploy automation failed: This should be on [HOLD for Payment 2024-08-26] according to #47512 prod deploy checklist, confirmed in #46962 (comment). |
Thanks for the heads up @rayane-djouah. I'll be out of office on the 26th - adding in a BZ buddy. |
Triggered auto assignment to @strepanier03 ( |
Payment Summary
I believe this is accurate, and no one else needs to be paid, but please correct me if I'm wrong, and I'll update. |
I'll come back to this in the afternoon and check. |
Correct! |
@strepanier03 - Offer accepted, Thanks! |
I've paid and closed the contract. Thanks all! |
Implement this section of the design doc for the
From
andTo
filters only!cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @strepanier03The text was updated successfully, but these errors were encountered: