Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] [$250] [Search v2.1] [App] Create From and To filter #46035

Closed
luacmartins opened this issue Jul 23, 2024 · 27 comments
Closed

[PAID] [$250] [Search v2.1] [App] Create From and To filter #46035

luacmartins opened this issue Jul 23, 2024 · 27 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 23, 2024

Implement this section of the design doc for the From and To filters only!

cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010c6f76a94b99da45
  • Upwork Job ID: 1817956261765409818
  • Last Price Increase: 2024-07-29
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @strepanier03
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 23, 2024
@luacmartins luacmartins self-assigned this Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 23, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
@trjExpensify trjExpensify moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Jul 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

@luacmartins, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Kicu
Copy link
Contributor

Kicu commented Jul 29, 2024

hello, I would like to work on this filter next, since my other PRs are almost done. Please assign me

@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor Overdue labels Jul 29, 2024
@melvin-bot melvin-bot bot changed the title [Search v2] [App] Create From and To filter [$250] [Search v2] [App] Create From and To filter Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010c6f76a94b99da45

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Jul 29, 2024
@Kicu
Copy link
Contributor

Kicu commented Jul 31, 2024

whoever knows if from + to filters should be allow multi selection of people?
@luacmartins @JmillsExpensify @shawnborton

And I'm assuming it should look the same as our other people pickers?
Screenshot 2024-07-31 at 14 11 05

@luacmartins
Copy link
Contributor Author

@Kicu yes, it should allow multi-select. The filters that allow multi-select can be found here in the doc

@luacmartins
Copy link
Contributor Author

and yes, it should look like the current contact selector

@rayane-djouah
Copy link
Contributor

@CherylWalsh - We need a copy to replace the "Assign it to me" for the self DM option section title for these two pages:

From Filter Page Screenshot Screenshot 2024-08-12 at 6 48 01 PM
To Filter Page Screenshot Screenshot 2024-08-12 at 6 48 22 PM

We are using a similar picker to the assignee page picker:

Task Assignee Page Screenshot

357146596-50836c43-cc19-4a84-9358-e54368ce2115

@luacmartins
Copy link
Contributor Author

@CherylWalsh actually, we don't need the copy since we decided to remove the sections altogether.

@luacmartins luacmartins removed the Waiting for copy User facing verbiage needs polishing label Aug 12, 2024
@rayane-djouah
Copy link
Contributor

PR is merged

Copy link

melvin-bot bot commented Aug 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rayane-djouah
Copy link
Contributor

PR deployed to production yesterday #46962 (comment)

Copy link

melvin-bot bot commented Aug 20, 2024

@Kicu, @luacmartins, @bfitzexpensify, @rayane-djouah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@rayane-djouah
Copy link
Contributor

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-08-26] according to #47512 prod deploy checklist, confirmed in #46962 (comment).

cc @bfitzexpensify

@bfitzexpensify
Copy link
Contributor

Thanks for the heads up @rayane-djouah.

I'll be out of office on the 26th - adding in a BZ buddy.

@bfitzexpensify bfitzexpensify removed their assignment Aug 21, 2024
@bfitzexpensify bfitzexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 21, 2024
@bfitzexpensify bfitzexpensify changed the title [$250] [Search v2.1] [App] Create From and To filter [PAY 26/8] [$250] [Search v2.1] [App] Create From and To filter Aug 21, 2024
Copy link

melvin-bot bot commented Aug 21, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@bfitzexpensify bfitzexpensify self-assigned this Aug 21, 2024
@luacmartins luacmartins changed the title [PAY 26/8] [$250] [Search v2.1] [App] Create From and To filter [HOLD for payment 2024-08-26] [$250] [Search v2.1] [App] Create From and To filter Aug 27, 2024
@luacmartins luacmartins added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Aug 27, 2024
@strepanier03
Copy link
Contributor

Payment Summary

I believe this is accurate, and no one else needs to be paid, but please correct me if I'm wrong, and I'll update.

@melvin-bot melvin-bot bot removed the Overdue label Aug 27, 2024
@strepanier03
Copy link
Contributor

I'll come back to this in the afternoon and check.

@rayane-djouah
Copy link
Contributor

I believe this is accurate, and no one else needs to be paid, but please correct me if I'm wrong, and I'll update.

Correct!

@rayane-djouah
Copy link
Contributor

@strepanier03 - Offer accepted, Thanks!

@strepanier03 strepanier03 changed the title [HOLD for payment 2024-08-26] [$250] [Search v2.1] [App] Create From and To filter [PAID] [$250] [Search v2.1] [App] Create From and To filter Aug 27, 2024
@strepanier03
Copy link
Contributor

I've paid and closed the contract. Thanks all!

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #expense Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

7 participants