Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Workspace settings - Unable to open Accounting page, loading spinner and error in console #45766

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 19, 2024 · 18 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login with any account
  3. Go to Account settings -> Workspace
  4. Open any WS or create a new one
  5. More future -> Enable Accounting
  6. Open the Accounting page

Expected Result:

Accounting page opens without any error

Actual Result:

Unable to open Accounting page, loading spinner and error in console

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6546719_1721344522559.bandicam_2024-07-19_02-06-00-497.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 19, 2024
Copy link

melvin-bot bot commented Jul 19, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@tsa321
Copy link
Contributor

tsa321 commented Jul 19, 2024

Back end issue, the returned onyxData from OpenPolicyAccountingPage:

ss-1

The error is from here:

responseOnyxData.forEach((onyxData) => {

@thienlnam thienlnam added the DeployBlocker Indicates it should block deploying the API label Jul 19, 2024
@alexpensify
Copy link
Contributor

@thienlnam - Since this is a backend issue, should it be internal or external? Thanks for the update!

@thienlnam thienlnam added the Internal Requires API changes or must be handled by Expensify staff label Jul 19, 2024
@aldo-expensify
Copy link
Contributor

Back end issue, the returned onyxData from OpenPolicyAccountingPage:

ss-1

I think that is expected from the backend response, in the testing steps we don't get to the point where we connect to QBO (or any other integrations) so it is expected that connections is null

@aldo-expensify aldo-expensify removed the Internal Requires API changes or must be handled by Expensify staff label Jul 19, 2024
@aldo-expensify aldo-expensify removed their assignment Jul 19, 2024
@aldo-expensify
Copy link
Contributor

This is not necessarily a backend problem, needs to be investigated first

@aldo-expensify
Copy link
Contributor

Doesn't seem to be a deploy blocker, I can reproduce in production:

image

@aldo-expensify aldo-expensify removed the DeployBlocker Indicates it should block deploying the API label Jul 19, 2024
@aldo-expensify
Copy link
Contributor

Maybe it is some change in Auth? since it is happening in staging and production?

@tsa321
Copy link
Contributor

tsa321 commented Jul 19, 2024

@aldo-expensify there is onyxData inside onyxData. I think the structure of the response is incorrect.

@aldo-expensify
Copy link
Contributor

ooh, that is a good catch, thanks, I'll look into that

@aldo-expensify aldo-expensify self-assigned this Jul 19, 2024
@aldo-expensify aldo-expensify added the Internal Requires API changes or must be handled by Expensify staff label Jul 19, 2024
@aldo-expensify
Copy link
Contributor

@aldo-expensify aldo-expensify added Reviewing Has a PR in review DeployBlocker Indicates it should block deploying the API labels Jul 19, 2024
@alexpensify
Copy link
Contributor

Thanks for the swift action @aldo-expensify!

@alexpensify
Copy link
Contributor

Keeping this one closed, no action is required on the BZ side and there is no payment. Everything was handled internally.

Copy link

melvin-bot bot commented Jul 23, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@alexpensify
Copy link
Contributor

@aldo-expensify - is this notice an error or do we need to come up with a plan to address it? Thanks!

@alexpensify alexpensify reopened this Jul 25, 2024
@aldo-expensify
Copy link
Contributor

I believe this is being addressed in the GH issue where this was mentioned.

@alexpensify
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants