[HOLD for payment 2024-08-09] [$125] Hold - LHN does not highlight the currently opened expense thread after holding an expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

issue found when validating #44810

Version Number: 9.0.7-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Submit only one expense.
5. Click on the expense preview.
6. Click on the report header.
7. Click Hol.d
8. Enter a reason and save it.
9. Close the education modal.

Expected Result:

LHN will show the currently opened report.

Actual Result:

LHN does not show the currently opened report (no highlight).
This only happens when there is only one expense.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6543322_1721086196172.20240716_071358.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a8c5c567045c8e05
• Upwork Job ID: 1816139733985028955
• Last Price Increase: 2024-07-24
• Automatic offers:
• ahmedGaber93 | Reviewer | 103273548
• dominictb | Contributor | 103273549

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN does not show the currently opened report (no highlight).
This only happens when there is only one expense.

What is the root cause of that problem?

We always pass the backTo params here and here as the transaction thread report so when we hold the expense in the combine report, we still go back to the transaction thread report which is hidden in LHN when it's a one transaction thread.

What changes do you think we should make in order to solve the problem?

We should add an extra param backTo for hold option here and use this as backTo param when we go to the hold reason page here and here

And when we add the hold option, pass the backTo param as the combine report url if the we're in the combine report. Otherwise pass it as the transaction thread report url

if (isExpenseReport && shouldShowHoldAction) {
    result.push(PromotedActions.hold({isTextHold: canHoldUnholdReportAction.canHoldRequest, reportAction: moneyRequestAction, backTo: ROUTES.REPORT_WITH_ID.getRoute(transactionThreadReportID ? report.reportID : moneyRequestAction?.childReportID ?? '-1')}));
}

App/src/pages/ReportDetailsPage.tsx

Lines 521 to 523 in 7d58aa6

	if (isExpenseReport && shouldShowHoldAction) {
	result.push(PromotedActions.hold({isTextHold: canHoldUnholdReportAction.canHoldRequest, reportAction: moneyRequestAction}));
	}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@robertjchen, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[RachCHopkins]

@robertjchen do you need me to do anything here?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a8c5c567045c8e05

[melvin-bot]

Current assignee @robertjchen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[robertjchen]

Thanks, LGTM as well!

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: set backTo params when hold #46268

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ahmedGaber93]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR: [CP Staging] fix: Search - Transaction RHP dismisses when holding/unholding expense from report details page. #44359
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44359/files#r1710270483
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open the App and create a new workspace.
2. Go to workspace chat and submit only one expense.
3. Click on the expense preview.
4. Click on the report header.
5. Click Hold
6. Enter a reason and save it.
7. Close the education modal.
8. Verify that: LHN will show and highlight the currently opened report.

Do we agree 👍 or 👎

[ahmedGaber93]

@RachCHopkins this issue is due for payment today.

[RachCHopkins]

Sorry for the delay @ahmedGaber93 I thought we were working on PST in which the 9th was my Saturday so I was not online.

Payment Summary:

• Contributor: @dominictb paid $125 via Upwork
• Contributor+: @ahmedGaber93 paid $125 via Upwork

Upwork job here

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.