Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-25] Add support for "Reuse existing connection" flow for NetSuite #45349

Closed
yuwenmemon opened this issue Jul 12, 2024 · 4 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Weekly KSv2

Comments

@yuwenmemon
Copy link
Contributor

@mananjadhav @shubham1206agra

One part of the design doc we missed was the Reuse Existing Connection flow.

Luckily, this has been implemented for Intacct, and the API was built out here so it be relatively simple to implement

Kapture.2024-07-12.at.12.29.20.mp4
Copy link

melvin-bot bot commented Jul 17, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 18, 2024
@melvin-bot melvin-bot bot changed the title Add support for "Reuse existing connection" flow for NetSuite [HOLD for payment 2024-07-25] Add support for "Reuse existing connection" flow for NetSuite Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-25. 🎊

@yuwenmemon
Copy link
Contributor Author

Part of project work from @mananjadhav so closing this out

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

1 participant