Investigate workflow job failing on main: lint / Run ESLint

[github-actions]

🚨 Failure Summary 🚨:

• 📋 Job Name: lint / Run ESLint
• 🔧 Failure in Workflow: Process new code merged to main
• 🔗 Triggered by PR: PR Link
• 👤 PR Author: @Krishna2323
• 🤝 Merged by: @MonilBhavsar
• 🐛 Error Message:
  failure: Process completed with exit code 134.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named lint / Run ESLint.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

1. Why the PR caused the job to fail?
2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

[MonilBhavsar]

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
No lint issues

[blazejkustra]

I'm able to reproduce this issue reliably on this PR but only locally @MonilBhavsar

[MonilBhavsar]

yes, I can reproduce locally too. Had to manually increase the node memory.
This actions is also failing with the same error https://github.com/Expensify/App/actions/runs/9674218522/job/26689446781

[blazejkustra]

I think we need to increase the node memory for now, I haven't found any other fixes as of now.

-    "lint": "eslint . --max-warnings=0 --cache --cache-location=node_modules/.cache/eslint",
+    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=0 --cache --cache-location=node_modules/.cache/eslint",

[blazejkustra]

This could be connected to these recent PRs:

• [NoQA] feat: react-compiler #42287 (some changes to eslintrc + experimental react compiler)
• [No QA] Upgrade ESLint #44112 (eslint was updated here)
• feat: script for downloading sourcemaps + symbolicating them #43894 (new tsconfig was added that could be connected to this, generating sourcemaps is expensive)

[blazejkustra]

Unfortunately ESLint can't be run in parallel (they even have a bounty for this 😅). Something that we could do going forward is to run many instances of ESLint at once for different parts of the project. That could help with the memory problem and speed up lint workflow.

[blazejkustra]

Ultimately it would be awesome to find the root cause why it takes so much memory (if it's a memory leak or not). I tried to debug it today with:

DEBUG=typescript-eslint:* npm run lint
// and
DEBUG=* npm run lint
// and
TIMING=1 DEBUG=eslint:cli-engine npx --node-options='--max-old-space-size=8120' eslint --quiet .

Buut, these logs are very verbose and hard to get any useful information out of it unfortunately.

[MonilBhavsar]

Thank you for looking! 👍

@roryabraham was quick and increased the node memory https://github.com/Expensify/App/pull/44497/files ⚡ 😄
So we should be good here