Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] [External] Create new Edit Card Limit page #44326

Closed
mountiny opened this issue Jun 24, 2024 · 23 comments
Closed

[Workspace Feeds] [External] Create new Edit Card Limit page #44326

mountiny opened this issue Jun 24, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jun 24, 2024

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

Issue OwnerCurrent Issue Owner: @VickyStash
Copy link

melvin-bot bot commented Jun 28, 2024

@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jun 28, 2024
@mountiny
Copy link
Contributor Author

Later phase of implementation

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@mountiny
Copy link
Contributor Author

Thanks

@VickyStash
Copy link
Contributor

VickyStash commented Jul 11, 2024

Updates:
WIP, I've implemented a new screen and route, just need to add a confirmation modal and prepare a PR. The PR should be ready on Monday (❗ tomorrow I'm OOO). Branch with updates: feature/44326-edit-card-limit

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@VickyStash
Copy link
Contributor

The PR has been opened for the review 👀

@mountiny
Copy link
Contributor Author

Leaving this open to integrate the BE

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 26, 2024
@melvin-bot melvin-bot bot changed the title [Workspace Feeds] [External] Create new Edit Card Limit page [HOLD for payment 2024-08-07] [Workspace Feeds] [External] Create new Edit Card Limit page Jul 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 7, 2024
Copy link

melvin-bot bot commented Aug 7, 2024

Issue is ready for payment but no BZ is assigned. @JmillsExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Aug 7, 2024

Payment Summary

Upwork Job

BugZero Checklist (@JmillsExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@JmillsExpensify
Copy link

$250 summary above is correct for @DylanDylann

@JmillsExpensify
Copy link

Also remind me, are you paid via Upwork or New Expensify?

@DylanDylann
Copy link
Contributor

This issue belongs to our project, There no need for payment

@VickyStash
Copy link
Contributor

Since UpdateExpensifyCardLimit API endpoint is ready I'm going to work on BE integration

@mountiny
Copy link
Contributor Author

mountiny commented Aug 8, 2024

@VickyStash thanks, hit us up in Slack if you have any questions

@JmillsExpensify
Copy link

Can I close this issue or should I keep it open?

@mountiny
Copy link
Contributor Author

mountiny commented Aug 9, 2024

We are still connecting it to the backend so lets keep it open but you do not have to be assigned

@JmillsExpensify JmillsExpensify changed the title [HOLD for payment 2024-08-07] [Workspace Feeds] [External] Create new Edit Card Limit page [Workspace Feeds] [External] Create new Edit Card Limit page Aug 9, 2024
@VickyStash
Copy link
Contributor

The API call was implemented during the page implementation. There are some minor fixes/updates to make the card limit update work as expected in the PR related to OpenPolicyExpensifyCardsPage API call integration.

I've tested how UpdateExpensifyCardLimit API call works, and the result looks as expected:
image

So we can just wait till the mentioned PR is merged and it should work as expected.

@mountiny
Copy link
Contributor Author

Perfect, thanks!

@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2024
@mountiny
Copy link
Contributor Author

Not overdue, we are actively working on this one

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

@MariaHCD, @VickyStash, @mountiny, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Aug 20, 2024
@mountiny
Copy link
Contributor Author

This can be closed now I think

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants