[HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create new Settlement Frequency page

[mountiny]

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

[melvin-bot]

@MariaHCD, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[koko57]

Taking this one 😃

[koko57]

WIP - changes are on this branch https://github.com/koko57/App/tree/feature/44311-card-settings-page. Tomorrow I'm ooo, I will continue on Monday.

[koko57]

Will get back to it tomorrow

[koko57]

Left the update here: #44311 (comment)

[koko57]

@MariaHCD @mountiny what should be the default option here? If according to the docs the settlement frequency should be stored either by adding the monthlySettlementDate prop (for monthly settlement) or erasing it (for daily settlement) I have to somehow differentiate if the selection was made or not. Should we block frequency for being changed and display the info after we set it to daily ourselves or it should be locked only when isMonthlySettlementAllowed is false?

[MariaHCD]

@koko57 Just to clarify, is your question what should the default settlement frequency be when the admin navigates to the Settlement Frequency page?

The settlement frequency is set when the Expensify Card is enabled on the policy (after the admin selects the VBBA). So in the sharedNVP_private_expensifyCardSettings_<workspaceAccountID> Onyx key, if the monthlySettlementDate is set, that means the frequency is "monthy", otherwise, it's "daily".

Should we block frequency for being changed and display the info after we set it to daily ourselves or it should be locked only when isMonthlySettlementAllowed is false?

So if there is no monthlySettlementDate and isMonthlySettltmentAllowed is false, we'll block updating the frequency.

Hope that helps!

[koko57]

@MariaHCD thanks a lot! ❤️ That was exactly what I needed to clarify 🙂

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[allgandalf]

The linked blocker was actually know before deploy (comment here), we are still developing the links so we can track #46083 and address it once we have the links

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Card settings page #45415

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[allgandalf]

No payment needed here, this is part of a project

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @miljakljajic you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@miljakljajic)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[allgandalf]

No payment needed here @miljakljajic and not overdue melvin, are we waiting for BE testing here?

[miljakljajic]

Do we need a regression test proposal here, or can we close?