[HOLD for payment 2024-08-07] [$250] mweb - Hold - Interstitial modal "Got it" is auto-dismissed when hold expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Create two manual money request
2. Go to the first expense > Select Hold from 3-Dot menu
3. Add reason to hold and tap Hold button

Expected Result:

Modal with Got it button should appear and user should tap Got it to dismiss the modal

Actual Result:

Interstitial modal "Got it" is auto-dismissed when hold expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519338_1718883358977.Recording__3259.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1513c97d5b0c258
• Upwork Job ID: 1805314680387652637
• Last Price Increase: 2024-07-15
• Automatic offers:
• dominictb | Contributor | 103250020

Issue Owner

Current Issue Owner: @alexpensify / @alexpensify

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e1513c97d5b0c258

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[alexpensify]

Waiting for proposals here

[hungvu193]

Waiting for proposals

[alexpensify]

We need proposals here

[alexpensify]

Heads up, I will be offline until Monday, July 8, 2024, and will not actively watch over this GitHub during that period.

I'll try to check in a few times. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

[hungvu193]

Still waiting for proposal

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hungvu193]

Same

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hungvu193]

Same here

[hungvu193]

@puneetlath little bump 👋

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

Sorry for the delay. Assigned @dominictb

[hungvu193]

@dominictb Do you have any ETA for the PR?

[dominictb]

PR will be ready by today!

[alexpensify]

It's not overdue; the PR is on the way.

[alexpensify]

Awesome, this PR is moving along, and we are waiting for it to go to production.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: remove popstate listener in popover #46357

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
• [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hungvu193] Determine if we should create a regression test for this bug.
• [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

Payouts due: August 7, 2024

• Contributor: $250 @dominictb - I completed the process in Upwork
• Contributor+: $250 @hungvu193 - Please submit a request in Chat

Upwork job is here.

Closing - I completed the payment process in Upwork. I'll revisit this GH for the regression test process.

[JmillsExpensify]

$250 approved for @hungvu193