[HOLD for payment 2024-07-24] [$250] Buttons are covered by keyboard and cutting off the view

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713930362161559

Action Performed:

1. Sign up with gmail
2. In the onboarding flow tap any option and tap name field
3. Sign out and sign in with existing account
4. Observe the magic code screen

Expected Result:

Buttons should be completely visible

Actual Result:

Buttons are covered by the keyboard and black patch covers in the sign in screen

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

RPReplay_Final1718743402.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0acece4b6e020ff
• Upwork Job ID: 1805457325237784450
• Last Price Increase: 2024-07-02
• Automatic offers:
• rayane-djouah | Reviewer | 103032748
• suneox | Contributor | 103032750
• eh2077 | Contributor | 103033350

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[adelekennedy]

I can't reproduce this - I'm on IOS web chrome, staging v1. 4. 84-3 - I can't reproduce but asked for more context and logs in Slack

[danielrvidal]

Okay, so I'm not super sure what is causing it. Here is what I can tell you.

1. Chrome, incognito latest version
2. iPhone 13 Pro
3. Go to new.expensify.com
4. Click on the sign in and it shows up
5. Sometimes I have to click in and out multiple times before it shows up

https://github.com/Expensify/App/assets/2364487/f00908ac-056f-4b5e-a1d4-1ffd33f37407
https://github.com/Expensify/App/assets/2364487/d16384b4-8e51-4fb8-960b-7bb88304f507

[adelekennedy]

I'm trying it on prod now and I can't totally recreate it, sometimes if I rapid click around the page and then back into the sign in field the black block will pop up for a second but doesn't stop me from signing in. I think it's the blank block space above the sign in GIF (at least that's what it looks like to me). Iphone 13, chrome incognito, Expensify version v1.4.85-7

It could be related to this? The associated PR was deployed last week which may be why it's not reproducible on staging

[adelekennedy]

@danielrvidal I'm still not able to reproduce this on the newest staging version, this is annoying but can you try it one more time on the newest staging?

[danielrvidal]

It does look like those PRs were supposed to handle it, but I'm still getting it if I go to staging.expensify.com. I'm wondering if it is has something to do with my pws trying to be suggested. Maybe that is causing the issue?

RPReplay_Final1719287328.mov

[adelekennedy]

Maybe? I think even if we can't nail the reproduction steps it's worth it to make this external and at least investigate

RPReplay_Final1719289328.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0acece4b6e020ff

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[Ariqkip]

Please re-state the problem that we are trying to solve in this issue.

1. Buttons are covered by keyboard and cutting off the view

What is the root cause of that problem?

• Overflow and Scroll Behavior: The container has overflow properties, it might not scroll properly when the keyboard is shown, causing elements to be hidden.

What changes do you think we should make in order to solve the problem?

•   Ensure that the input field or button scrolls into view when focused And Adjust CSS to ensure that containers can scroll when necessary
  

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link:https://www.upwork.com/freelancers/~01e8fca580ad3567b3

[melvin-bot]

📣 @Ariqkip! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Virtual viewport resize incorrectly on mobile webKit browsers

What is the root cause of that problem?

The virtual viewport on iOS browsers resizes with a delay, and when we toggle the keyboard quickly multiple times the screen's updated window height isn't correct.

Pre-produce

RPReplay_Final1719502340.MP4

What changes do you think we should make in order to solve the problem?

We can use the existing feature to get the cached virtual viewport height. currently, it's only support for Safari browser at this line.

App/src/hooks/useWindowDimensions/index.ts

Line 26 in e75f1c4

const isCachedViewportHeight = useCachedViewportHeight && Browser.isMobileSafari();

So, we will update it to isMobileWebKit which also covers mobile Safari.

-   const isCachedViewportHeight = useCachedViewportHeight && Browser.isMobileSafari();
+   const isCachedViewportHeight = useCachedViewportHeight && Browser.isMobileWebKit();

Then add shouldUseCachedViewportHeight property into ScreenWrapper on the SignInPage

What alternative solutions did you explore? (Optional)

[rayane-djouah]

Reviewing now

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rayane-djouah]

@eh2077 is taking over

[eh2077]

Yeah, @thienlnam can you assign it to me please? So that I can be assigned to review the PR

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• handle visual viewport scroll incorrect on ios chrome  #44999

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @eh2077 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox / @eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@suneox / @eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@suneox / @eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@suneox / @eh2077] Determine if we should create a regression test for this bug.
• [@suneox / @eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

payments made - do we need a regression test here @eh2077?

[adelekennedy]

bump @eh2077

[eh2077]

Checklist

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR: There's no such a PR that causes this issue. It's an edge case that's not covered before.
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@eh2077] Determine if we should create a regression test for this bug. No, I don't think we need a regression test for this as it's an edge case and the related code won't be changed often.

cc @adelekennedy