[HOLD for payment 2024-07-17] [$250] Workspace - Unable to proceed to the next tab from "Invite new members" with Enter key

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4635357&group_by=cases:section_id&group_id=229065&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with any account that has a workspace
3. Navigate to the workspace Members page
4. Select a few members
5. Focus the empty input field
6. Press the Enter key

Expected Result:

I should be taken to the "Add message" page.

Actual Result:

Unable to proceed to the next tab from "Invite new members" with Enter key.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6514912_1718539202533.bandicam_2024-06-16_13-55-54-755.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0150ec85dec4b39a10
• Upwork Job ID: 1802772880999647514
• Last Price Increase: 2024-06-24
• Automatic offers:
• Krishna2323 | Contributor | 102873717

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Unable to proceed to the next tab from "Invite new members" with Enter key

What is the root cause of that problem?

Enter key press is disabled for FormAlertWithSubmitButton using disablePressOnEnter prop. The prop was added to fix this issue, but now we can safely remove that because shouldBubble will be false when we have a valid focused item in the selection list and submit button won't capture that key press. Also the focus is removed when we select any user so user can easily submit the form when no user is focused.

App/src/pages/workspace/WorkspaceInvitePage.tsx

Line 284 in beb8e38

disablePressOnEnter

App/src/components/SelectionList/BaseSelectionList.tsx

Line 603 in beb8e38

shouldBubble: !flattenedSections.allOptions[focusedIndex],

What changes do you think we should make in order to solve the problem?

We need to remove disablePressOnEnter prop. Also need to update the same in InviteReportParticipantsPage and RoomInvitePage and check for other components as well.

What alternative solutions did you explore? (Optional)

[sakluger]

Agree that this is a bug related to wave-collect.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0150ec85dec4b39a10

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

@sakluger, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sakluger]

Hey @abdulrahuman5196, could you please review Krishna's proposal?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sakluger]

I'm going to assign a new C+ to keep this issue moving.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Krishna2323]

@Ollyws PR ready for review ^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Unable to proceed to the next tab from Invite new members with Enter key. #44542

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Unable to proceed to the next tab from Invite new members with Enter key. #44542

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

I'm not sure why this switched to Daily so early - it just deployed to prod yesterday. I'm switching it back to weekly.

@Ollyws can you please complete the BZ checklist by July 22? Thanks!

[sakluger]

My bad - payment is due on 7/17. Switching back to daily!

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

This behaviour seems to have been intentionally added a long time ago in #21935, so not really a bug.

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

    1. Open workspace members page > Invite member
    2. Select users using keyboard > Press enter when no option is selected
    3. Verify you are proceeded to the next tab
    4. Open a group chat > Click on header > Select members > Invite
    5. Select users using keyboard > Press enter when no option is selected
    6. Verify you are proceeded to the next tab
    7. Open a room chat > Click on header > Select members > Invite Members
    8. Select users using keyboard > Press enter when no option is selected
    9. Verify selected members are invited

Do we agree 👍 or 👎

[Ollyws]

Requested in ND.

[JmillsExpensify]

@sakluger can I get a payment summary please?

[sakluger]

Summarizing payment on this issue:

Contributor: @Krishna2323 $250, paid via Upwork
Contributor+: @Ollyws $250, please request on Newdot

[JmillsExpensify]

@250 approved for @Ollyws