Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Report Fields] [External] Implement the policy report fields creation flow #43684

Closed
mountiny opened this issue Jun 13, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jun 13, 2024

[Main tracking issue].(https://github.com/Expensify/Expensify/issues/365155)

Design doc link.

Implement the following section of the design doc:
https://docs.google.com/document/d/10b7pTVvgpB6_O8sRTKaCzZEVM3Ba6hxnIwyyQSSXCLY/edit#bookmark=kix.3s2yd5r621zv

This might technically be on hold for #43677 but I think Callstack can start on these in parallel using feature branch.

Include unit tests for the optimistic actions

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @sakluger
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Daily KSv2 NewFeature Something to build that is a new item. labels Jun 13, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Current assignees @rushatgabhane and @shubham1206agra are eligible for the External assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 13, 2024
@mountiny mountiny moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #expense Jun 13, 2024
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2024
@waterim
Copy link
Contributor

waterim commented Jun 13, 2024

Hello, Im Artem from Callstack and would like to help with this issue

@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37
Copy link
Contributor

Actively working on the issue.

@rezkiy37
Copy link
Contributor

Actively working on the issue. I've opened a draft PR.

Progress

WIP.mp4

@rezkiy37
Copy link
Contributor

Updates:

  1. Aligned on how to use the date and list values pickers in Slack.
  2. Integrated the correct date row.
  3. Added all subtitles.
  4. Started to work on the list values selector.

@rezkiy37
Copy link
Contributor

Updates:

  1. Integrating the list values creation flow.

@rezkiy37
Copy link
Contributor

Updates:

  1. Discussion in Slack.
  2. Integrated the list values creation flow.
  3. Integrated the default list value selector.

@rezkiy37
Copy link
Contributor

Updates:

  1. Discussion in Slack.
  2. Integrated the bulk list values actions.
  3. Added all translations.
  4. Ingteragrated validations.
  5. Integrated a draft create function.

@rezkiy37
Copy link
Contributor

Updates:

  1. Discussion in Slack.
  2. Applied review suggestions.
  3. Integrated createReportField function.
  4. Tested how it works with API.
  5. Started creating automated tests.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 28, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 28, 2024
@rezkiy37
Copy link
Contributor

I've opened the PR (#44275) for review.

@mountiny
Copy link
Contributor Author

mountiny commented Jul 5, 2024

I believe the PR was merged so we are done here

@mountiny mountiny closed this as completed Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #expense Jul 5, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Report Fields] [External] Implement the policy report fields creation flow [HOLD for payment 2024-07-17] [Report Fields] [External] Implement the policy report fields creation flow Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [Report Fields] [External] Implement the policy report fields creation flow [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Report Fields] [External] Implement the policy report fields creation flow Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Development

No branches or pull requests

6 participants