Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Attachment - Attachment preview does not show the image #43660

Closed
3 of 6 tasks
lanitochka17 opened this issue Jun 13, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Go to + > Add attachment
  4. Upload an image

Expected Result:

Attachment preview will show the image

Actual Result:

Attachment preview does not show the image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6511960_1718284381762.attachment.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0102fdf94fdad3d721
  • Upwork Job ID: 1801255717183191652
  • Last Price Increase: 2024-06-13
  • Automatic offers:
    • hungvu193 | Reviewer | 102725541
Issue OwnerCurrent Issue Owner: @hungvu193
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@flodnv FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@flodnv
Copy link
Contributor

flodnv commented Jun 13, 2024

I was able to reproduce, not sure what caused this, posted here: https://expensify.slack.com/archives/C01GTK53T8Q/p1718287685135869?thread_ts=1718285665.504579&cid=C01GTK53T8Q

@flodnv flodnv added the External Added to denote the issue can be worked on by a contributor label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0102fdf94fdad3d721

@melvin-bot melvin-bot bot changed the title Attachment - Attachment preview does not show the image [$250] Attachment - Attachment preview does not show the image Jun 13, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@luacmartins luacmartins removed the DeployBlocker Indicates it should block deploying the API label Jun 13, 2024
@bernhardoj
Copy link
Contributor

Same root cause as #43657

@flodnv
Copy link
Contributor

flodnv commented Jun 13, 2024

Thanks for pointing that out @bernhardoj 🙇

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@luacmartins
Copy link
Contributor

I removed C+ assignment since this is already being handled in this issue

@luacmartins luacmartins added the Reviewing Has a PR in review label Jun 13, 2024
@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 14, 2024
@mountiny mountiny added the Daily KSv2 label Jun 14, 2024
@mountiny
Copy link
Contributor

This is fixed now, we can close it as payments are handled here #43657

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 17, 2024
@melvin-bot melvin-bot bot changed the title [$250] Attachment - Attachment preview does not show the image [HOLD for payment 2024-06-24] [$250] Attachment - Attachment preview does not show the image Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-24. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 21, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-24] [$250] Attachment - Attachment preview does not show the image [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Attachment - Attachment preview does not show the image Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-28. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants