[HOLD for payment 2024-08-02] No "Mark as Cash" button is displayed in Pending Expense

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.82-0
Reproducible in staging?: Yes
Reproducible in production?: Yes

Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856

Issue reported by: Applause - Internal Team

Action Performed:

Setup

1. Login with applausetester+[email protected]
2. Navigate to Account settings > Wallet
3. Make sure that under Assigned Cards the "Discover" card is assigned under the applause.expensifail domain

If this ^ is not setup, follow these steps:

1. Login with [email protected] or an admin of the domain
2. Navigate to Domain Control > Company Cards
3. Assign a card to the account applausetester+[email protected]

STEPS to reproduce the issue

1. Navigate to a workspace transaction that is in pending state
2. Verify a "Mark as cash" button is displayed below the pending state message
3. Click on the "Mark as cash" button
4. Verify the pending state is removed
5. Verify that in the expense transaction thread, there is a system message indicating that you marked the expense as cash, e.g. marked this receipt as cash

Expected Result:

Mark as cash button should be displayed in the header of the transaction thread when the expense is in pending state

Actual Result:

Mark as cash button is not displayed.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

@JmillsExpensify, @yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

I went ahead and put this in #wave-control. Yuwen and I are more focused on NetSuite/Intacct implementations this week, though we will circle back to this one soon.

[melvin-bot]

@JmillsExpensify, @yuwenmemon Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

@yuwenmemon it'd be good to get to the bottom of this one once NetSuite/Intacct are farther into implementation.

[melvin-bot]

@JmillsExpensify @yuwenmemon this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@JmillsExpensify, @yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

We're prioritizing higher-value things atm

[melvin-bot]

@JmillsExpensify, @yuwenmemon Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Still working on higher value things.

[melvin-bot]

@JmillsExpensify, @yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@yuwenmemon I think we should start circling back on this one. What do you think?

[yuwenmemon]

Yep! I'm getting slightly more bandwidth each day outside of NS and Intacct and #fast-apis so taking a look at this soon 🎉

[yuwenmemon]

@smelaa Any idea why the button would not be showing here? I believe you built out this UI originally...

[yuwenmemon]

Ah apologies, looks like this is more closely related to work from @BrtqKr - sending a PR for their review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove unneccessary hiding of mark as cash button on submitted reports #45739

If no regressions arise, payment will be issued on 2024-08-02. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@yuwenmemon] The PR that introduced the bug has been identified. Link to the PR:
• [@yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@yuwenmemon] Determine if we should create a regression test for this bug.
• [@yuwenmemon] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@JmillsExpensify, @yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

No payment due and regression tests being added centrally. I'll close this one.