[$250] Chat - Edit box is not focused

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.80-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to any chat with a chat history and at least one edited comment
2. Click on any other comment and edit

Expected Result:

The edit box is automatically focused

Actual Result:

The compose box is focused instead of the edit box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504353_1717706123822.2024-06-06_23_33_04.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01033dcbb85796aa97
• Upwork Job ID: 1798824665211065518
• Last Price Increase: 2024-06-06

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01033dcbb85796aa97

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[bernhardoj]

I noticed this issue at #42645 (comment) and will be fixed there too.

[trjExpensify]

If you noticed this issue last week @bernhardoj is it reproducible on production and thus not a deploy blocker?

[bernhardoj]

I can't repro it on prod, unfortunately.

[trjExpensify]

Hm, then I'm not sure if that's the root cause then. @eh2077 have you looked into this?

[luacmartins]

I think this issue was caused by commit 29992cf894d0ebcdcb2e20311435638ee1dedf58 from #42738. I'll demote this since it's a small issue and let the contributor fix it. @tsa321 can you please comment here so I can assign it to you?

[tsa321]

@luacmartins Yes, I will make a revert PR

[tsa321]

@luacmartins The revert PR is here : #43298

[Taiwrash]

I can fix this if no one has picked it before now...

[melvin-bot]

📣 @Taiwrash! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Taiwrash]

What next to continue with this?

[tsa321]

@Taiwrash this bug is caused by my PR and we want to fix.

[Taiwrash]

@Taiwrash this bug is caused by my PR and we want to fix.

you mean, a simple revert of your PR will fix it?

[tsa321]

@Taiwrash yes, and we want to fix the original issue too.

[Taiwrash]

@Taiwrash yes, and we want to fix the original issue too.

if i get this right, it means i can go for original issue instead?

[tsa321]

@Taiwrash the PR of original issue that I am assigned to causing this regression. The PR is merged recently so it is currently regression period. Since my PR causing this issue, so I must fix this issue.

Anyways, in latest main after bumping react-native-live-markdown version this issue and the original issue isn't reproducible thanks to @bernhardoj PR on react-native-live-markdown. But I notice the original issue is reproducible in edit report action composer too. Now I am intending make a PR to fix that.

@Taiwrash I suggest you to search for other open Help Wanted issue.

[kaushiktd]

The latest code from new pull seems to be fixing this issue.
screen-capture.webm

[eh2077]

Not overdue. This is a regression from #42368 and @tsa321 is actively re-working the fix here #43343

I think @DylanDylann as the original C+ should take care of this, so I'm going to unassign myself.

cc @luacmartins

[luacmartins]

We reverted the offending PR. I think we can close this one.