-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription-Expensify is barely visible in Expensify approved section in device setting mode #43195
Comments
Triggered auto assignment to @roryabraham ( |
Triggered auto assignment to @garrettmknight ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Looks definitely front-end only. |
Triggered auto assignment to @dannymcclain ( |
@dannymcclain any thoughts on a more appropriate color scheme for Expensify Approved! and light mode here? |
Pretty positive this has already been fixed in an open PR. Let me try to track it down. |
Am I mistaken or is this currently only accessible by navigating directly to the URL? |
Ok you can see here where this was caught: #42975 (comment) And then a commit was pushed to update it. And then @amyevans approved and merged the changes. So I think it's just still waiting to be deployed to staging. |
Sweet - thanks for the quick work @dannymcclain - I think we can close this then. |
Also yes, I don't believe there's any way to actually get to this subscription page in production. This is all still very much in the implementation phase. |
cool cool. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
issue found when validating #42975
Version Number: 1.4.80-1
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
Expensify should be clearly visible
Actual Result:
Expensify is barely visible because it has the same color as the background
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6504104_1717690155844.Recording__3129.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: