Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [HOLD for payment 2024-06-28] [HybridApp] CI/CD deploy can fail due to duplicate verison #43185

Closed
AndrewGable opened this issue Jun 6, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@AndrewGable
Copy link
Contributor

Problem

We have seen a failure due to a duplicate version for iOS/Android when we create a deploy for HybridApp from NewDot's deploy.

https://github.com/Expensify/Mobile-Deploy/actions/runs/9401950203/job/25895053938

Solution

Fix it!

@AndrewGable AndrewGable added the Daily KSv2 label Jun 6, 2024
@AndrewGable AndrewGable self-assigned this Jun 6, 2024
@AndrewGable AndrewGable moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 6, 2024
@AndrewGable
Copy link
Contributor Author

This will be solved when we implement the last bit here: #37858

Syncing versions

In order to make bug tracking easier across HybridApp and NewDot, we’ll keep the versions in-sync. In order to do this, we’ll first create a PR to update the HybridApp version to 9.0.0.0 in order to make it clear we have a major update. Then we will manually update the NewDot version to match the current HybridApp version (9.0.0.0).

Then, we’ll update Mobile-Deploy’s deploy.yml workflow to accept a version string as an input, and pass that to Mobile-Expensify’s shell script to bump the app version. Then when triggering the HybridApp deploy from NewDot, we’ll pass the current NewDot version.
That way, the versions of HybridApp and NewDot will always be in sync, and it’s easy to reconcile bug reports coming from either app (though generally, most bug reports should be coming from HybridApp, while the bulk of the source code comes from NewDot).

@melvin-bot melvin-bot bot added the Overdue label Jun 10, 2024
@AndrewGable
Copy link
Contributor Author

Going to work on this today, additionally we should stop using main and start using the staging branch for HybridApp NewDot submodule

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

@AndrewGable Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jun 17, 2024

@AndrewGable Still overdue 6 days?! Let's take care of this!

@AndrewGable
Copy link
Contributor Author

Hoping to work on this one today

@melvin-bot melvin-bot bot removed the Overdue label Jun 18, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Jun 19, 2024
@melvin-bot melvin-bot bot changed the title [HybridApp] CI/CD deploy can fail due to duplicate verison [HOLD for payment 2024-06-28] [HybridApp] CI/CD deploy can fail due to duplicate verison Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-28. 🎊

@trjExpensify
Copy link
Contributor

Looks like we didn't have C+ on that, so can we move to close this issue if it's on prod now?

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jun 24, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jun 25, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 25, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-28] [HybridApp] CI/CD deploy can fail due to duplicate verison [HOLD for payment 2024-07-02] [HOLD for payment 2024-06-28] [HybridApp] CI/CD deploy can fail due to duplicate verison Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-02. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-02] [HOLD for payment 2024-06-28] [HybridApp] CI/CD deploy can fail due to duplicate verison [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [HOLD for payment 2024-06-28] [HybridApp] CI/CD deploy can fail due to duplicate verison Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants