[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Expense - App crashes when submitting expense on a newly created workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.80-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline
3. Create a new workspace
4. Go to workspace chat
5. Go to + > Submit expense > Manual
6. Enter amount > Next

Expected Result:

App will not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6503926_1717681105186.submit.mp4

logs (2).txt

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[grgia]

#42786

[grgia]

#42141 might be related to this PR @nkdengineer

[grgia]

https://github.com/Expensify/App/pull/43052/files or this one, @MonilBhavsar

[MonilBhavsar]

Ah, this is critical. I'll look after dinner

[MonilBhavsar]

Okay, I confirmed this is not coming from my PR. Commented on the suspicious PR #42330

[MonilBhavsar]

I think we can return early here if distanceRate is null. But I'm not completely sure if it's a real fix

App/src/libs/DistanceRequestUtils.ts

Line 92 in fad70bf

const distanceRate = Object.values(mileageRates).find((rate) => rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE) ?? Object.values(mileageRates)[0];

[luacmartins]

I can work on a fix for this

[luacmartins]

Fixed in staging. Closing.

web.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix crash when submitting expense on a newly created workspace #43226

If no regressions arise, payment will be issued on 2024-06-18. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix crash when submitting expense on a newly created workspace #43226

If no regressions arise, payment will be issued on 2024-06-20. 🎊