Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji - When editing an emoji only message, the "Composer" is expanded #42891

Closed
3 of 6 tasks
kavimuru opened this issue May 31, 2024 · 5 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented May 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when validating #43615
Version Number: 1.4.78-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Access staging.new.expensify.com and sign into a valid account
  2. Open any chat
  3. Send an emoji only message
  4. Long-press/right-click on the message and choose Edit message
  5. Observe the position of the green check mark and all other elements within the composer

Expected Result:

User expects it to be centered

Actual Result:

The composer is much "larger" than on Prod, leading certain elements to appear to be misaligned to the bottom margins.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6496936_1717118045241.Staging_x_Prod.mp4
Bug6496936_1717117919145!Button_is_misaligned_

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 31, 2024
Copy link

melvin-bot bot commented May 31, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 31, 2024
Copy link

melvin-bot bot commented May 31, 2024

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@bernhardoj
Copy link
Contributor

It's an expected change from this PR. We had a discussion there too.

@rlinoz
Copy link
Contributor

rlinoz commented May 31, 2024

@bernhardoj is right, so I will go ahead and close this one.

@rlinoz rlinoz closed this as completed May 31, 2024
@rlinoz rlinoz removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels May 31, 2024
@Gonals Gonals added Daily KSv2 and removed Hourly KSv2 labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants