Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-28] [$250] [MEDIUM] Add "View Trip Details" row to newDot trip expenses #42814

Closed
twisterdotcom opened this issue May 29, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@twisterdotcom
Copy link
Contributor

twisterdotcom commented May 29, 2024

Add a link out to https://www.travel.expensify.com/trips/$tripID/ on each trip expense booked with Expensify Travel

image

Issue OwnerCurrent Issue Owner: @twisterdotcom
@twisterdotcom twisterdotcom added Weekly KSv2 NewFeature Something to build that is a new item. labels May 29, 2024
@twisterdotcom twisterdotcom self-assigned this May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

@twisterdotcom twisterdotcom changed the title Add "View Trip Details" row to newDot trip expenses [MEDIUM] Add "View Trip Details" row to newDot trip expenses May 29, 2024
@twisterdotcom twisterdotcom moved this to Medium - V1.5 in [#whatsnext] #travel May 29, 2024
@twisterdotcom twisterdotcom changed the title [MEDIUM] Add "View Trip Details" row to newDot trip expenses [$250] [MEDIUM] Add "View Trip Details" row to newDot trip expenses Jun 3, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@twisterdotcom
Copy link
Contributor Author

I will do a manual contract for this

@rushatgabhane
Copy link
Member

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
@twisterdotcom
Copy link
Contributor Author

How is this going now @rushatgabhane? Latest update from yesterday here: #43081 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2024
@stitesExpensify stitesExpensify self-assigned this Jun 14, 2024
@rushatgabhane
Copy link
Member

We had some TS issues in main, all resolved and ready to merge.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 21, 2024
@melvin-bot melvin-bot bot changed the title [$250] [MEDIUM] Add "View Trip Details" row to newDot trip expenses [HOLD for payment 2024-06-28] [$250] [MEDIUM] Add "View Trip Details" row to newDot trip expenses Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 21, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@twisterdotcom
Copy link
Contributor Author

No need for regression steps here. Will pay out on 28th.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 27, 2024
@twisterdotcom
Copy link
Contributor Author

Payment Summary:

@github-project-automation github-project-automation bot moved this from Medium - V1.5 to Done in [#whatsnext] #travel Jun 28, 2024
@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

5 participants